summaryrefslogtreecommitdiff
path: root/transcode.c
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-11-29 07:44:09 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-11-29 07:44:09 +0000
commited2205ff430453569fe26cd06c6c89a0b20b1e35 (patch)
tree46672cb1d41a08d0577f8f5aea5d7e93eba25b4a /transcode.c
parentc07ec8434596749d453365db45edd0479219e86d (diff)
merge revision(s) 51488,51489: [Backport #11416]
* transcode.c (rb_econv_open0): rb_econv_t::source_encoding_name and rb_econv_t::destination_encoding_name should refer static strings always or NULL. [ruby-core:70247] [Bug #11416] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52784 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'transcode.c')
-rw-r--r--transcode.c16
1 files changed, 11 insertions, 5 deletions
diff --git a/transcode.c b/transcode.c
index 5e20fd73a4..d5add7b6e7 100644
--- a/transcode.c
+++ b/transcode.c
@@ -993,6 +993,7 @@ rb_econv_open0(const char *sname, const char *dname, int ecflags)
if (*sname == '\0' && *dname == '\0') {
num_trans = 0;
entries = NULL;
+ sname = dname = "";
}
else {
struct trans_open_t toarg;
@@ -3246,10 +3247,10 @@ rb_econv_init_by_convpath(VALUE self, VALUE convpath,
}
if (first) {
- *senc_p = NULL;
- *denc_p = NULL;
- *sname_p = "";
- *dname_p = "";
+ *senc_p = NULL;
+ *denc_p = NULL;
+ *sname_p = "";
+ *dname_p = "";
}
ec->source_encoding_name = *sname_p;
@@ -3390,7 +3391,10 @@ econv_init(int argc, VALUE *argv, VALUE self)
}
if (!ec) {
- rb_exc_raise(rb_econv_open_exc(sname, dname, ecflags));
+ VALUE exc = rb_econv_open_exc(sname, dname, ecflags);
+ RB_GC_GUARD(snamev);
+ RB_GC_GUARD(dnamev);
+ rb_exc_raise(exc);
}
if (!DECORATOR_P(sname, dname)) {
@@ -3398,6 +3402,8 @@ econv_init(int argc, VALUE *argv, VALUE self)
senc = make_dummy_encoding(sname);
if (!denc)
denc = make_dummy_encoding(dname);
+ RB_GC_GUARD(snamev);
+ RB_GC_GUARD(dnamev);
}
ec->source_encoding = senc;