summaryrefslogtreecommitdiff
path: root/tool
diff options
context:
space:
mode:
authornagachika <nagachika@ruby-lang.org>2022-10-15 16:33:24 +0900
committernagachika <nagachika@ruby-lang.org>2022-10-15 16:33:24 +0900
commitfa2ddb67c5a19d1c165fbba4102ca7a397fa50d5 (patch)
treef8af6ff31d58ab9fd576282f7c65e01746ffe4a7 /tool
parentd4dadf5d9baf2998b95550cb5bd7f55a4f11a729 (diff)
merge revision(s) 79fa27acc452c50ae47936880f91424e729fda72:
rbinstall: Also do `Gem.ruby` patching for unpacked bundled gems Pointing `Gem.ruby` to the newly installed ruby gives mkmf the right inputs to build extensions in bundled gems. Previously, this patching was only done for compressed bundled gems. This patch also prevents `tool/fake.rb` from propagating to the child process running mkmf for the native extension. The way `tool/fake.rb` changes mkmf variables using `Kernel#trace_var` created spooky action at a distance which made debugging difficult. AppVeyor Windows CI started to fail starting with 8a3663789c52ec5635194656af6b69d3d03120ee because it enabled extension building for bundled gems on mswin. This patch should address the CI failures. --- tool/rbinstall.rb | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Diffstat (limited to 'tool')
-rwxr-xr-xtool/rbinstall.rb8
1 files changed, 7 insertions, 1 deletions
diff --git a/tool/rbinstall.rb b/tool/rbinstall.rb
index b7ecb9a47b..b643fc8676 100755
--- a/tool/rbinstall.rb
+++ b/tool/rbinstall.rb
@@ -1034,6 +1034,13 @@ install?(:ext, :comm, :gem, :'bundled-gems') do
specifications_dir = File.join(gem_dir, "specifications")
build_dir = Gem::StubSpecification.gemspec_stub("", ".bundle", ".bundle").extensions_dir
+ # We are about to build extensions, and want to configure extensions with the
+ # newly installed ruby.
+ Gem.instance_variable_set(:@ruby, with_destdir(File.join(bindir, ruby_install_name)))
+ # Prevent fake.rb propagation. It conflicts with the natural mkmf configs of
+ # the newly installed ruby.
+ ENV.delete('RUBYOPT')
+
File.foreach("#{srcdir}/gems/bundled_gems") do |name|
next if /^\s*(?:#|$)/ =~ name
next unless /^(\S+)\s+(\S+).*/ =~ name
@@ -1061,7 +1068,6 @@ install?(:ext, :comm, :gem, :'bundled-gems') do
end
next if gems.empty?
if defined?(Zlib)
- Gem.instance_variable_set(:@ruby, with_destdir(File.join(bindir, ruby_install_name)))
silent = Gem::SilentUI.new
gems.each do |gem|
package = Gem::Package.new(gem)