summaryrefslogtreecommitdiff
path: root/thread.c
diff options
context:
space:
mode:
authorNARUSE, Yui <naruse@airemix.jp>2021-02-08 19:13:52 +0900
committerNARUSE, Yui <naruse@airemix.jp>2021-02-08 19:13:52 +0900
commit9aba46d8d80473594e567dff1652626e7b2a77b0 (patch)
tree5a5bf0d45e6874414fad875f8144dc8dad44be7d /thread.c
parent6e8e7005724e9b67a80ca0bcf455aa1c8bef31cf (diff)
merge revision(s) 6f727853cee41195b67ee5d793c1ac23fe1a6ae0,b2674c1fd725b43adf51af7935c780359d70c2a4: [Backport #17482]
only main thread can modify vm->ubf_async_safe vm->ubf_async_safe is VM global resource and only main thread can manipulate it. [Bug #17482] --- thread.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) unblock thread is only for main ractor. other ractors should not have a unblock thread. This patch fixes 6f727853cee41195b67ee5d793c1ac23fe1a6ae0. --- thread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Diffstat (limited to 'thread.c')
-rw-r--r--thread.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/thread.c b/thread.c
index 22b77b7f13..ddb4621ee2 100644
--- a/thread.c
+++ b/thread.c
@@ -1650,6 +1650,8 @@ rb_nogvl(void *(*func)(void *), void *data1,
void *val = 0;
rb_execution_context_t *ec = GET_EC();
rb_thread_t *th = rb_ec_thread_ptr(ec);
+ rb_vm_t *vm = rb_ec_vm_ptr(ec);
+ bool is_main_thread = vm->ractor.main_thread == th;
int saved_errno = 0;
VALUE ubf_th = Qfalse;
@@ -1657,9 +1659,9 @@ rb_nogvl(void *(*func)(void *), void *data1,
ubf = ubf_select;
data2 = th;
}
- else if (ubf && rb_ractor_living_thread_num(th->ractor) == 1) {
+ else if (ubf && rb_ractor_living_thread_num(th->ractor) == 1 && is_main_thread) {
if (flags & RB_NOGVL_UBF_ASYNC_SAFE) {
- th->vm->ubf_async_safe = 1;
+ vm->ubf_async_safe = 1;
}
else {
ubf_th = rb_thread_start_unblock_thread();
@@ -1671,7 +1673,7 @@ rb_nogvl(void *(*func)(void *), void *data1,
saved_errno = errno;
}, ubf, data2, flags & RB_NOGVL_INTR_FAIL);
- th->vm->ubf_async_safe = 0;
+ if (is_main_thread) vm->ubf_async_safe = 0;
if ((flags & RB_NOGVL_INTR_FAIL) == 0) {
RUBY_VM_CHECK_INTS_BLOCKING(ec);