summaryrefslogtreecommitdiff
path: root/thread.c
diff options
context:
space:
mode:
authorko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-06-30 22:29:34 +0000
committerko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-06-30 22:29:34 +0000
commitfa4514e4fedc1e1390200e3901e2add22a4a27b4 (patch)
tree1570296a48f3bd30e36bf682431defe49f05846e /thread.c
parent198c2570e740280bf7f00a38d311ade19c27fef7 (diff)
* thread.c (rb_threadptr_check_signal): only wake up main thread.
* thread.c (rb_threadptr_execute_interrupts_common): check signal deliverly if it is main thread. fixes [ruby-dev:44005] [Ruby 1.9 - Bug #4950] * bootstraptest/test_fork.rb: add a test for above. * signal.c (rb_get_next_signal): skip if signal_buff is empty. (check signal_buff.size first) * vm_core.h: remove unused variable rb_thread_t::exec_signal. * thread.c (rb_thread_check_trap_pending): check rb_signal_buff_size() because rb_thread_t::exec_signal is no longer available. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'thread.c')
-rw-r--r--thread.c20
1 files changed, 8 insertions, 12 deletions
diff --git a/thread.c b/thread.c
index ab547a1d0a..9e869069fc 100644
--- a/thread.c
+++ b/thread.c
@@ -981,7 +981,7 @@ rb_thread_check_ints(void)
int
rb_thread_check_trap_pending(void)
{
- return GET_THREAD()->exec_signal != 0;
+ return rb_signal_buff_size() != 0;
}
/* This function can be called in blocking region. */
@@ -1269,14 +1269,15 @@ rb_threadptr_execute_interrupts_common(rb_thread_t *th)
enum rb_thread_status status = th->status;
int timer_interrupt = interrupt & 0x01;
int finalizer_interrupt = interrupt & 0x04;
+ int sig;
th->status = THREAD_RUNNABLE;
/* signal handling */
- if (th->exec_signal) {
- int sig = th->exec_signal;
- th->exec_signal = 0;
- rb_signal_exec(th, sig);
+ if (th == th->vm->main_thread) {
+ while ((sig = rb_get_next_signal()) != 0) {
+ rb_signal_exec(th, sig);
+ }
}
/* exception from another thread */
@@ -2934,14 +2935,9 @@ rb_gc_save_machine_context(rb_thread_t *th)
void
rb_threadptr_check_signal(rb_thread_t *mth)
{
- int sig;
-
/* mth must be main_thread */
-
- if (!mth->exec_signal && (sig = rb_get_next_signal()) > 0) {
- thread_debug("main_thread: %s, sig: %d\n",
- thread_status_name(mth->status), sig);
- mth->exec_signal = sig;
+ if (rb_signal_buff_size() > 0) {
+ /* wakeup main thread */
rb_threadptr_interrupt(mth);
}
}