diff options
author | Jeremy Evans <code@jeremyevans.net> | 2019-09-20 19:06:22 -0700 |
---|---|---|
committer | Jeremy Evans <code@jeremyevans.net> | 2019-11-18 01:00:25 +0200 |
commit | c5c05460ac20abcbc0ed686eb4acf06da7a39a79 (patch) | |
tree | 991109a68f3b1cd2e256a936701d3b2badd3ddac /test/test_tempfile.rb | |
parent | 7b6a8b5b54448235e17ed187d9d73f56893e1b6f (diff) |
Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access
or modification of $SAFE from Ruby-level, as well as warning when calling
all public C functions related to $SAFE.
This modifies some internal functions that took a safe level argument
to no longer take the argument.
rb_require_safe now warns, rb_require_string has been added as a
version that takes a VALUE and does not warn.
One public C function that still takes a safe level argument and that
this doesn't warn for is rb_eval_cmd. We may want to consider
adding an alternative method that does not take a safe level argument,
and warn for rb_eval_cmd.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/2476
Diffstat (limited to 'test/test_tempfile.rb')
-rw-r--r-- | test/test_tempfile.rb | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/test/test_tempfile.rb b/test/test_tempfile.rb index 7c911a1bf7..6b087f9207 100644 --- a/test/test_tempfile.rb +++ b/test/test_tempfile.rb @@ -31,17 +31,6 @@ class TestTempfile < Test::Unit::TestCase assert_equal "hello world", File.read(path) end - def test_saves_in_dir_tmpdir_by_default - t = tempfile("foo") - assert_equal Dir.tmpdir, File.dirname(t.path) - bug3733 = '[ruby-dev:42089]' - assert_nothing_raised(SecurityError, bug3733) { - proc {$SAFE = 1; File.expand_path(Dir.tmpdir)}.call - } - ensure - $SAFE = 0 - end - def test_saves_in_given_directory subdir = File.join(Dir.tmpdir, "tempfile-test-#{rand}") Dir.mkdir(subdir) |