diff options
| author | naruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-01-03 18:11:47 +0000 |
|---|---|---|
| committer | naruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-01-03 18:11:47 +0000 |
| commit | 887dced42e51e79734c75e77bdfb69c56493e6e3 (patch) | |
| tree | 760588e555437d6e106f2571cc817b673b4ffe94 /test/erb | |
| parent | dc96b227d5df77f80098dc7172c91789673fa4d1 (diff) | |
merge revision(s) 61497: [Backport #14243]
erb.rb: preserve the behavior for invalid syntax
comment. Fix regression at r58948.
I even don't want to deprecate it because deprecation needs to lex all
embedded Ruby script using Ripper and it would be slow. So Let me just
keep this behavior of Ruby 2.4. No change is the best compatibility.
This commit stopped using String#-@ because it's harmful for "ambiguous
first argument" warning if we really want to maintain this behavior.
[Bug #14243]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@61581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test/erb')
| -rw-r--r-- | test/erb/test_erb.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/test/erb/test_erb.rb b/test/erb/test_erb.rb index 46f81c778b..045ce5129b 100644 --- a/test/erb/test_erb.rb +++ b/test/erb/test_erb.rb @@ -622,6 +622,13 @@ EOS erb = @erb.new("<%= 1 %>") assert_raise(TypeError) { erb.result_with_hash({ 1 => "1" }) } end + + # Bug#14243 + def test_half_working_comment_backward_compatibility + assert_nothing_raised do + @erb.new("<% # comment %>\n").result + end + end end class TestERBCoreWOStrScan < TestERBCore |