diff options
author | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2015-06-30 21:07:18 +0000 |
---|---|---|
committer | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2015-06-30 21:07:18 +0000 |
commit | b49075cdf15a733cf7a9b1f9ce9d06c40828db3d (patch) | |
tree | ffe20a1e7d680301a086083bd3ee77b081eba29d /struct.c | |
parent | c7548028a20c555b692c07c37b3ffd2d416bb434 (diff) |
move RB_GC_GUARD responsibility to rb_add_method_iseq
This simplifies all the callers and makes code easier to use
and review. I was confused about the need for RB_GC_GUARD
in define_{aset,aref}_method of struct.c without reading
rb_add_method_iseq.
Likewise, do the same for rb_iseq_clone, where the GC guard
only seems neccesary iff RGenGC is disabled.
* vm_method.c (rb_add_method_iseq): add RB_GC_GUARD
* class.c (clone_method): remove RB_GC_GUARD
* struct.c (define_aref_method): ditto
(define_aset_method): ditto
* vm.c (vm_define_method):
* iseq.c (rb_iseq_clone): add RB_GC_GUARD
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'struct.c')
-rw-r--r-- | struct.c | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -288,7 +288,6 @@ define_aref_method(VALUE nstr, VALUE name, VALUE off) VALUE iseqval = rb_method_for_self_aref(name, off, rb_vm_opt_struct_aref); rb_add_method_iseq(nstr, SYM2ID(name), iseqval, NULL, METHOD_VISI_PUBLIC); - RB_GC_GUARD(iseqval); } static void @@ -298,7 +297,6 @@ define_aset_method(VALUE nstr, VALUE name, VALUE off) VALUE iseqval = rb_method_for_self_aset(name, off, rb_vm_opt_struct_aset); rb_add_method_iseq(nstr, SYM2ID(name), iseqval, NULL, METHOD_VISI_PUBLIC); - RB_GC_GUARD(iseqval); } static VALUE |