* string.c (rb_str_sub_bang): calling rb_str_modify() should be just

	  before actually modifying the string.
	  fixed: [ruby-dev:30211] (originally reported by zunda)

	* patchlevel 18.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_5@11646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

1 files changed, 1 insertions, 1 deletions

diff --git a/string.c b/string.c
index 4651960389..58fa0362fc 100644
--- a/string.c
+++ b/string.c
@@ -1963,7 +1963,6 @@ rb_str_sub_bang(argc, argv, str)
 
     pat = get_pat(argv[0], 1);
     if (rb_reg_search(pat, str, 0, 0) >= 0) {
-	rb_str_modify(str);
 	match = rb_backref_get();
 	regs = RMATCH(match)->regs;
 
@@ -1979,6 +1978,7 @@ rb_str_sub_bang(argc, argv, str)
 	else {
 	    repl = rb_reg_regsub(repl, str, regs);
 	}
+	rb_str_modify(str);
 	if (OBJ_TAINTED(repl)) tainted = 1;
 	plen = END(0) - BEG(0);
 	if (RSTRING(repl)->len > plen) {