diff options
author | Takashi Kokubun <takashikkbn@gmail.com> | 2023-08-23 14:30:20 -0700 |
---|---|---|
committer | Takashi Kokubun <takashikkbn@gmail.com> | 2023-08-23 14:32:26 -0700 |
commit | d7f1ea71555c4d359de529b6058e4338ae247063 (patch) | |
tree | a88e8e8333e4cdacbaad7ebd89c4c7648826a8a7 /spec | |
parent | 43c2c1ed4814c6e1f0d0d0ec88641e12bf5aa290 (diff) |
Quarantine a very flaky spec
https://github.com/ruby/ruby/actions/runs/5956398507/job/16157091112
This has been extremely flaky on macOS GitHub Actions.
Benoit suggested to quarantine it if it's too problematic (it is) and
there's no reasonable fix in a short time (it already took too long).
So this commit follows the suggestion.
We should remove revert this once rb_cloexec_open() is fixed.
Diffstat (limited to 'spec')
-rw-r--r-- | spec/ruby/core/io/write_spec.rb | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/spec/ruby/core/io/write_spec.rb b/spec/ruby/core/io/write_spec.rb index 2e39b4fadd..4a26f8dbaf 100644 --- a/spec/ruby/core/io/write_spec.rb +++ b/spec/ruby/core/io/write_spec.rb @@ -203,15 +203,19 @@ describe "IO.write" do rm_r @fifo end - it "writes correctly" do - thr = Thread.new do - IO.read(@fifo) - end - begin - string = "hi" - IO.write(@fifo, string).should == string.length - ensure - thr.join + # rb_cloexec_open() is currently missing a retry on EINTR. + # @ioquatix is looking into fixing it. Quarantined until it's done. + quarantine! do + it "writes correctly" do + thr = Thread.new do + IO.read(@fifo) + end + begin + string = "hi" + IO.write(@fifo, string).should == string.length + ensure + thr.join + end end end end |