Drop support for ruby 2.4 from ruby/spec

4 files changed, 202 insertions, 246 deletions

diff --git a/spec/ruby/core/enumerable/all_spec.rb b/spec/ruby/core/enumerable/all_spec.rb
index 8af80896a9..ae255c662c 100644
--- a/spec/ruby/core/enumerable/all_spec.rb
+++ b/spec/ruby/core/enumerable/all_spec.rb
@@ -26,15 +26,6 @@ describe "Enumerable#all?" do
     -> { {}.all?(1, 2, 3) }.should raise_error(ArgumentError)
   end
 
-  ruby_version_is ""..."2.5" do
-    it "raises an ArgumentError when any arguments provided" do
-      -> { @enum.all?(Proc.new {}) }.should raise_error(ArgumentError)
-      -> { @enum.all?(nil) }.should raise_error(ArgumentError)
-      -> { @empty.all?(1) }.should raise_error(ArgumentError)
-      -> { @enum1.all?(1) {} }.should raise_error(ArgumentError)
-    end
-  end
-
   it "does not hide exceptions out of #each" do
     -> {
       EnumerableSpecs::ThrowingEach.new.all?
@@ -133,69 +124,67 @@ describe "Enumerable#all?" do
     end
   end
 
-  ruby_version_is "2.5" do
-    describe 'when given a pattern argument' do
-      it "calls `===` on the pattern the return value " do
-        pattern = EnumerableSpecs::Pattern.new { |x| x >= 0 }
-        @enum1.all?(pattern).should == false
-        pattern.yielded.should == [[0], [1], [2], [-1]]
-      end
+  describe 'when given a pattern argument' do
+    it "calls `===` on the pattern the return value " do
+      pattern = EnumerableSpecs::Pattern.new { |x| x >= 0 }
+      @enum1.all?(pattern).should == false
+      pattern.yielded.should == [[0], [1], [2], [-1]]
+    end
 
-      # may raise an exception in future versions
-      ruby_version_is ""..."2.6" do
-        it "ignores block" do
-          @enum2.all?(NilClass) { raise }.should == false
-          [1, 2, nil].all?(NilClass) { raise }.should == false
-          {a: 1}.all?(Array) { raise }.should == true
-        end
+    # may raise an exception in future versions
+    ruby_version_is ""..."2.6" do
+      it "ignores block" do
+        @enum2.all?(NilClass) { raise }.should == false
+        [1, 2, nil].all?(NilClass) { raise }.should == false
+        {a: 1}.all?(Array) { raise }.should == true
       end
+    end
 
-      it "always returns true on empty enumeration" do
-        @empty.all?(Integer).should == true
-        [].all?(Integer).should == true
-        {}.all?(NilClass).should == true
-      end
+    it "always returns true on empty enumeration" do
+      @empty.all?(Integer).should == true
+      [].all?(Integer).should == true
+      {}.all?(NilClass).should == true
+    end
 
-      it "does not hide exceptions out of #each" do
-        -> {
-          EnumerableSpecs::ThrowingEach.new.all?(Integer)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of #each" do
+      -> {
+        EnumerableSpecs::ThrowingEach.new.all?(Integer)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "returns true if the pattern never returns false or nil" do
-        pattern = EnumerableSpecs::Pattern.new { |x| 42 }
-        @enum.all?(pattern).should == true
+    it "returns true if the pattern never returns false or nil" do
+      pattern = EnumerableSpecs::Pattern.new { |x| 42 }
+      @enum.all?(pattern).should == true
 
-        [1, 42, 3].all?(pattern).should == true
+      [1, 42, 3].all?(pattern).should == true
 
-        pattern = EnumerableSpecs::Pattern.new { |x| Array === x }
-        {a: 1, b: 2}.all?(pattern).should == true
-      end
+      pattern = EnumerableSpecs::Pattern.new { |x| Array === x }
+      {a: 1, b: 2}.all?(pattern).should == true
+    end
 
-      it "returns false if the pattern ever returns false or nil" do
-        pattern = EnumerableSpecs::Pattern.new { |x| x >= 0 }
-        @enum1.all?(pattern).should == false
-        pattern.yielded.should == [[0], [1], [2], [-1]]
+    it "returns false if the pattern ever returns false or nil" do
+      pattern = EnumerableSpecs::Pattern.new { |x| x >= 0 }
+      @enum1.all?(pattern).should == false
+      pattern.yielded.should == [[0], [1], [2], [-1]]
 
-        [1, 2, 3, -1].all?(pattern).should == false
+      [1, 2, 3, -1].all?(pattern).should == false
 
-        pattern = EnumerableSpecs::Pattern.new { |x| x[1] >= 0 }
-        {a: 1, b: -1}.all?(pattern).should == false
-      end
+      pattern = EnumerableSpecs::Pattern.new { |x| x[1] >= 0 }
+      {a: 1, b: -1}.all?(pattern).should == false
+    end
 
-      it "does not hide exceptions out of pattern#===" do
-        pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
-        -> {
-          @enum.all?(pattern)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of pattern#===" do
+      pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
+      -> {
+        @enum.all?(pattern)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "calls the pattern with gathered array when yielded with multiple arguments" do
-        multi = EnumerableSpecs::YieldsMulti.new
-        pattern = EnumerableSpecs::Pattern.new { true }
-        multi.all?(pattern).should == true
-        pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
-      end
+    it "calls the pattern with gathered array when yielded with multiple arguments" do
+      multi = EnumerableSpecs::YieldsMulti.new
+      pattern = EnumerableSpecs::Pattern.new { true }
+      multi.all?(pattern).should == true
+      pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
   end
 end
diff --git a/spec/ruby/core/enumerable/any_spec.rb b/spec/ruby/core/enumerable/any_spec.rb
index c800fe2d4b..0202506d10 100644
--- a/spec/ruby/core/enumerable/any_spec.rb
+++ b/spec/ruby/core/enumerable/any_spec.rb
@@ -26,15 +26,6 @@ describe "Enumerable#any?" do
     -> { {}.any?(1, 2, 3) }.should raise_error(ArgumentError)
   end
 
-  ruby_version_is ""..."2.5" do
-    it "raises an ArgumentError when any arguments provided" do
-      -> { @enum.any?(Proc.new {}) }.should raise_error(ArgumentError)
-      -> { @enum.any?(nil) }.should raise_error(ArgumentError)
-      -> { @empty.any?(1) }.should raise_error(ArgumentError)
-      -> { @enum1.any?(1) {} }.should raise_error(ArgumentError)
-    end
-  end
-
   it "does not hide exceptions out of #each" do
     -> {
       EnumerableSpecs::ThrowingEach.new.any?
@@ -147,68 +138,66 @@ describe "Enumerable#any?" do
     end
   end
 
-  ruby_version_is "2.5" do
-    describe 'when given a pattern argument' do
-      it "calls `===` on the pattern the return value " do
-        pattern = EnumerableSpecs::Pattern.new { |x| x == 2 }
-        @enum1.any?(pattern).should == true
-        pattern.yielded.should == [[0], [1], [2]]
-      end
+  describe 'when given a pattern argument' do
+    it "calls `===` on the pattern the return value " do
+      pattern = EnumerableSpecs::Pattern.new { |x| x == 2 }
+      @enum1.any?(pattern).should == true
+      pattern.yielded.should == [[0], [1], [2]]
+    end
 
-      # may raise an exception in future versions
-      ruby_version_is ""..."2.6" do
-        it "ignores block" do
-          @enum2.any?(NilClass) { raise }.should == true
-          [1, 2, nil].any?(NilClass) { raise }.should == true
-          {a: 1}.any?(Array) { raise }.should == true
-        end
+    # may raise an exception in future versions
+    ruby_version_is ""..."2.6" do
+      it "ignores block" do
+        @enum2.any?(NilClass) { raise }.should == true
+        [1, 2, nil].any?(NilClass) { raise }.should == true
+        {a: 1}.any?(Array) { raise }.should == true
       end
+    end
 
-      it "always returns false on empty enumeration" do
-        @empty.any?(Integer).should == false
-        [].any?(Integer).should == false
-        {}.any?(NilClass).should == false
-      end
+    it "always returns false on empty enumeration" do
+      @empty.any?(Integer).should == false
+      [].any?(Integer).should == false
+      {}.any?(NilClass).should == false
+    end
 
-      it "does not hide exceptions out of #each" do
-        -> {
-          EnumerableSpecs::ThrowingEach.new.any?(Integer)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of #each" do
+      -> {
+        EnumerableSpecs::ThrowingEach.new.any?(Integer)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "returns true if the pattern ever returns a truthy value" do
-        @enum2.any?(NilClass).should == true
-        pattern = EnumerableSpecs::Pattern.new { |x| 42 }
-        @enum.any?(pattern).should == true
+    it "returns true if the pattern ever returns a truthy value" do
+      @enum2.any?(NilClass).should == true
+      pattern = EnumerableSpecs::Pattern.new { |x| 42 }
+      @enum.any?(pattern).should == true
 
-        [1, 42, 3].any?(pattern).should == true
+      [1, 42, 3].any?(pattern).should == true
 
-        pattern = EnumerableSpecs::Pattern.new { |x| x == [:b, 2] }
-        {a: 1, b: 2}.any?(pattern).should == true
-      end
+      pattern = EnumerableSpecs::Pattern.new { |x| x == [:b, 2] }
+      {a: 1, b: 2}.any?(pattern).should == true
+    end
 
-      it "returns false if the block never returns other than false or nil" do
-        pattern = EnumerableSpecs::Pattern.new { |x| nil }
-        @enum1.any?(pattern).should == false
-        pattern.yielded.should == [[0], [1], [2], [-1]]
+    it "returns false if the block never returns other than false or nil" do
+      pattern = EnumerableSpecs::Pattern.new { |x| nil }
+      @enum1.any?(pattern).should == false
+      pattern.yielded.should == [[0], [1], [2], [-1]]
 
-        [1, 2, 3].any?(pattern).should == false
-        {a: 1}.any?(pattern).should == false
-      end
+      [1, 2, 3].any?(pattern).should == false
+      {a: 1}.any?(pattern).should == false
+    end
 
-      it "does not hide exceptions out of pattern#===" do
-        pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
-        -> {
-          @enum.any?(pattern)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of pattern#===" do
+      pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
+      -> {
+        @enum.any?(pattern)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "calls the pattern with gathered array when yielded with multiple arguments" do
-        multi = EnumerableSpecs::YieldsMulti.new
-        pattern = EnumerableSpecs::Pattern.new { false }
-        multi.any?(pattern).should == false
-        pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
-      end
+    it "calls the pattern with gathered array when yielded with multiple arguments" do
+      multi = EnumerableSpecs::YieldsMulti.new
+      pattern = EnumerableSpecs::Pattern.new { false }
+      multi.any?(pattern).should == false
+      pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
   end
 end
diff --git a/spec/ruby/core/enumerable/none_spec.rb b/spec/ruby/core/enumerable/none_spec.rb
index 7c17e58a13..8c886736ab 100644
--- a/spec/ruby/core/enumerable/none_spec.rb
+++ b/spec/ruby/core/enumerable/none_spec.rb
@@ -20,15 +20,6 @@ describe "Enumerable#none?" do
     -> { {}.none?(1, 2, 3) }.should raise_error(ArgumentError)
   end
 
-  ruby_version_is ""..."2.5" do
-    it "raises an ArgumentError when any arguments provided" do
-      -> { @enum.none?(Proc.new {}) }.should raise_error(ArgumentError)
-      -> { @enum.none?(nil) }.should raise_error(ArgumentError)
-      -> { @empty.none?(1) }.should raise_error(ArgumentError)
-      -> { @enum.none?(1) {} }.should raise_error(ArgumentError)
-    end
-  end
-
   it "does not hide exceptions out of #each" do
     -> {
       EnumerableSpecs::ThrowingEach.new.none?
@@ -102,66 +93,64 @@ describe "Enumerable#none?" do
     end
   end
 
-  ruby_version_is "2.5" do
-    describe 'when given a pattern argument' do
-      it "calls `===` on the pattern the return value " do
-        pattern = EnumerableSpecs::Pattern.new { |x| x == 3 }
-        @enum1.none?(pattern).should == true
-        pattern.yielded.should == [[0], [1], [2], [-1]]
-      end
+  describe 'when given a pattern argument' do
+    it "calls `===` on the pattern the return value " do
+      pattern = EnumerableSpecs::Pattern.new { |x| x == 3 }
+      @enum1.none?(pattern).should == true
+      pattern.yielded.should == [[0], [1], [2], [-1]]
+    end
 
-      # may raise an exception in future versions
-      ruby_version_is ""..."2.6" do
-        it "ignores block" do
-          @enum2.none?(Integer) { raise }.should == true
-          [1, 2, nil].none?(TrueClass) { raise }.should == true
-          {a: 1}.none?(Hash) { raise }.should == true
-        end
+    # may raise an exception in future versions
+    ruby_version_is ""..."2.6" do
+      it "ignores block" do
+        @enum2.none?(Integer) { raise }.should == true
+        [1, 2, nil].none?(TrueClass) { raise }.should == true
+        {a: 1}.none?(Hash) { raise }.should == true
       end
+    end
 
-      it "always returns true on empty enumeration" do
-        @empty.none?(Integer).should == true
-        [].none?(Integer).should == true
-        {}.none?(NilClass).should == true
-      end
+    it "always returns true on empty enumeration" do
+      @empty.none?(Integer).should == true
+      [].none?(Integer).should == true
+      {}.none?(NilClass).should == true
+    end
 
-      it "does not hide exceptions out of #each" do
-        -> {
-          EnumerableSpecs::ThrowingEach.new.none?(Integer)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of #each" do
+      -> {
+        EnumerableSpecs::ThrowingEach.new.none?(Integer)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "returns true if the pattern never returns a truthy value" do
-        @enum2.none?(Integer).should == true
-        pattern = EnumerableSpecs::Pattern.new { |x| nil }
-        @enum.none?(pattern).should == true
+    it "returns true if the pattern never returns a truthy value" do
+      @enum2.none?(Integer).should == true
+      pattern = EnumerableSpecs::Pattern.new { |x| nil }
+      @enum.none?(pattern).should == true
 
-        [1, 42, 3].none?(pattern).should == true
-        {a: 1, b: 2}.none?(pattern).should == true
-      end
+      [1, 42, 3].none?(pattern).should == true
+      {a: 1, b: 2}.none?(pattern).should == true
+    end
 
-      it "returns false if the pattern ever returns other than false or nil" do
-        pattern = EnumerableSpecs::Pattern.new { |x| x < 0 }
-        @enum1.none?(pattern).should == false
-        pattern.yielded.should == [[0], [1], [2], [-1]]
+    it "returns false if the pattern ever returns other than false or nil" do
+      pattern = EnumerableSpecs::Pattern.new { |x| x < 0 }
+      @enum1.none?(pattern).should == false
+      pattern.yielded.should == [[0], [1], [2], [-1]]
 
-        [1, 2, 3, -1].none?(pattern).should == false
-        {a: 1}.none?(Array).should == false
-      end
+      [1, 2, 3, -1].none?(pattern).should == false
+      {a: 1}.none?(Array).should == false
+    end
 
-      it "does not hide exceptions out of pattern#===" do
-        pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
-        -> {
-          @enum.none?(pattern)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of pattern#===" do
+      pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
+      -> {
+        @enum.none?(pattern)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "calls the pattern with gathered array when yielded with multiple arguments" do
-        multi = EnumerableSpecs::YieldsMulti.new
-        pattern = EnumerableSpecs::Pattern.new { false }
-        multi.none?(pattern).should == true
-        pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
-      end
+    it "calls the pattern with gathered array when yielded with multiple arguments" do
+      multi = EnumerableSpecs::YieldsMulti.new
+      pattern = EnumerableSpecs::Pattern.new { false }
+      multi.none?(pattern).should == true
+      pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
   end
 end
diff --git a/spec/ruby/core/enumerable/one_spec.rb b/spec/ruby/core/enumerable/one_spec.rb
index 2ae8b3efa4..46a10d68eb 100644
--- a/spec/ruby/core/enumerable/one_spec.rb
+++ b/spec/ruby/core/enumerable/one_spec.rb
@@ -20,15 +20,6 @@ describe "Enumerable#one?" do
     -> { {}.one?(1, 2, 3) }.should raise_error(ArgumentError)
   end
 
-  ruby_version_is ""..."2.5" do
-    it "raises an ArgumentError when any arguments provided" do
-      -> { @enum.one?(Proc.new {}) }.should raise_error(ArgumentError)
-      -> { @enum.one?(nil) }.should raise_error(ArgumentError)
-      -> { @empty.one?(1) }.should raise_error(ArgumentError)
-      -> { @enum.one?(1) {} }.should raise_error(ArgumentError)
-    end
-  end
-
   it "does not hide exceptions out of #each" do
     -> {
       EnumerableSpecs::ThrowingEach.new.one?
@@ -93,77 +84,75 @@ describe "Enumerable#one?" do
   end
 
 
-  ruby_version_is "2.5" do
-    describe 'when given a pattern argument' do
-      it "calls `===` on the pattern the return value " do
-        pattern = EnumerableSpecs::Pattern.new { |x| x == 1 }
-        @enum1.one?(pattern).should == true
-        pattern.yielded.should == [[0], [1], [2], [-1]]
-      end
+  describe 'when given a pattern argument' do
+    it "calls `===` on the pattern the return value " do
+      pattern = EnumerableSpecs::Pattern.new { |x| x == 1 }
+      @enum1.one?(pattern).should == true
+      pattern.yielded.should == [[0], [1], [2], [-1]]
+    end
 
-      # may raise an exception in future versions
-      ruby_version_is ""..."2.6" do
-        it "ignores block" do
-          @enum2.one?(NilClass) { raise }.should == true
-          [1, 2, nil].one?(NilClass) { raise }.should == true
-          {a: 1}.one?(Array) { raise }.should == true
-        end
+    # may raise an exception in future versions
+    ruby_version_is ""..."2.6" do
+      it "ignores block" do
+        @enum2.one?(NilClass) { raise }.should == true
+        [1, 2, nil].one?(NilClass) { raise }.should == true
+        {a: 1}.one?(Array) { raise }.should == true
       end
+    end
 
-      it "always returns false on empty enumeration" do
-        @empty.one?(Integer).should == false
-        [].one?(Integer).should == false
-        {}.one?(NilClass).should == false
-      end
+    it "always returns false on empty enumeration" do
+      @empty.one?(Integer).should == false
+      [].one?(Integer).should == false
+      {}.one?(NilClass).should == false
+    end
 
-      it "does not hide exceptions out of #each" do
-        -> {
-          EnumerableSpecs::ThrowingEach.new.one?(Integer)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of #each" do
+      -> {
+        EnumerableSpecs::ThrowingEach.new.one?(Integer)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "returns true if the pattern returns a truthy value only once" do
-        @enum2.one?(NilClass).should == true
-        pattern = EnumerableSpecs::Pattern.new { |x| x == 2 }
-        @enum1.one?(pattern).should == true
+    it "returns true if the pattern returns a truthy value only once" do
+      @enum2.one?(NilClass).should == true
+      pattern = EnumerableSpecs::Pattern.new { |x| x == 2 }
+      @enum1.one?(pattern).should == true
 
-        [1, 2, 42, 3].one?(pattern).should == true
+      [1, 2, 42, 3].one?(pattern).should == true
 
-        pattern = EnumerableSpecs::Pattern.new { |x| x == [:b, 2] }
-        {a: 1, b: 2}.one?(pattern).should == true
-      end
+      pattern = EnumerableSpecs::Pattern.new { |x| x == [:b, 2] }
+      {a: 1, b: 2}.one?(pattern).should == true
+    end
 
-      it "returns false if the pattern returns a truthy value more than once" do
-        pattern = EnumerableSpecs::Pattern.new { |x| !x }
-        @enum2.one?(pattern).should == false
-        pattern.yielded.should == [[nil], [false]]
+    it "returns false if the pattern returns a truthy value more than once" do
+      pattern = EnumerableSpecs::Pattern.new { |x| !x }
+      @enum2.one?(pattern).should == false
+      pattern.yielded.should == [[nil], [false]]
 
-        [1, 2, 3].one?(Integer).should == false
-        {a: 1, b: 2}.one?(Array).should == false
-      end
+      [1, 2, 3].one?(Integer).should == false
+      {a: 1, b: 2}.one?(Array).should == false
+    end
 
-      it "returns false if the pattern never returns a truthy value" do
-        pattern = EnumerableSpecs::Pattern.new { |x| nil }
-        @enum1.one?(pattern).should == false
-        pattern.yielded.should == [[0], [1], [2], [-1]]
+    it "returns false if the pattern never returns a truthy value" do
+      pattern = EnumerableSpecs::Pattern.new { |x| nil }
+      @enum1.one?(pattern).should == false
+      pattern.yielded.should == [[0], [1], [2], [-1]]
 
-        [1, 2, 3].one?(pattern).should == false
-        {a: 1}.one?(pattern).should == false
-      end
+      [1, 2, 3].one?(pattern).should == false
+      {a: 1}.one?(pattern).should == false
+    end
 
-      it "does not hide exceptions out of pattern#===" do
-        pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
-        -> {
-          @enum.one?(pattern)
-        }.should raise_error(RuntimeError)
-      end
+    it "does not hide exceptions out of pattern#===" do
+      pattern = EnumerableSpecs::Pattern.new { raise "from pattern" }
+      -> {
+        @enum.one?(pattern)
+      }.should raise_error(RuntimeError)
+    end
 
-      it "calls the pattern with gathered array when yielded with multiple arguments" do
-        multi = EnumerableSpecs::YieldsMulti.new
-        pattern = EnumerableSpecs::Pattern.new { false }
-        multi.one?(pattern).should == false
-        pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
-      end
+    it "calls the pattern with gathered array when yielded with multiple arguments" do
+      multi = EnumerableSpecs::YieldsMulti.new
+      pattern = EnumerableSpecs::Pattern.new { false }
+      multi.one?(pattern).should == false
+      pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
   end
 end