diff options
| author | Utkarsh Gupta <utkarsh@debian.org> | 2020-06-21 23:23:23 +0530 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
| commit | d0810fdee453fef24492dcfdb0876d57f3b90d6a (patch) | |
| tree | 8648328c73e241b8c36298529c7396b1323d80c0 /spec/bundler/commands/newgem_spec.rb | |
| parent | 077dcacb0892d8cd36cc45ae8869031c62502919 (diff) | |
[rubygems/rubygems] Use latest version of rubocop for RUBY_VERSION > 2.4
With older versions of rubocop, the dependency on
`jaro_winkler` seems to be a pain.
However, in the later versions of rubocop, this
dependency was dropped. So we only need to use
the older version for ruby2.3.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9cd87eaee3
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
Diffstat (limited to 'spec/bundler/commands/newgem_spec.rb')
| -rw-r--r-- | spec/bundler/commands/newgem_spec.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb index 4427a65e88..33ea61738b 100644 --- a/spec/bundler/commands/newgem_spec.rb +++ b/spec/bundler/commands/newgem_spec.rb @@ -177,7 +177,8 @@ RSpec.describe "bundle gem" do it "run rubocop inside the generated gem with no offenses" do prepare_gemspec(bundled_app(gem_name, "#{gem_name}.gemspec")) - gems = ["rake", "rubocop -v 0.80.1"] + rubocop_version = RUBY_VERSION > "2.4" ? "0.85.1" : "0.80.1" + gems = ["rake", "rubocop -v #{rubocop_version}"] path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app(gem_name)) : system_gem_path realworld_system_gems gems, :path => path bundle "exec rubocop --config .rubocop.yml", :dir => bundled_app(gem_name) |