diff options
author | Matt Valentine-House <matt@eightbitraptor.com> | 2022-12-13 15:11:57 +0000 |
---|---|---|
committer | Peter Zhu <peter@peterzhu.ca> | 2022-12-15 09:04:30 -0500 |
commit | 9c54466e299aa91af225bc2d92a3d7755730948f (patch) | |
tree | 13d941effd31465b31b99d3ea0263a1dbee2e7be /shape.h | |
parent | 723cca6d82ecaeb41d7922571a88f15439048098 (diff) |
Fix Object Movement allocation in GC
When moving Objects between size pools we have to assign a new shape.
This happened during updating references - we tried to create a new shape
tree that mirrored the existing tree, but based on the root shape of the
new size pool.
This causes allocations to happen if the new tree doesn't already exist,
potentially triggering a GC, during GC.
This commit changes object movement to look for a pre-existing new tree
during object movement, and if that tree does not exist, we don't move
the object to the new pool.
This allows us to remove the shape allocation from update references.
Co-Authored-By: Peter Zhu <peter@peterzhu.ca>
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/6926
Diffstat (limited to 'shape.h')
-rw-r--r-- | shape.h | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -178,6 +178,8 @@ rb_shape_t * rb_shape_alloc(ID edge_name, rb_shape_t * parent); rb_shape_t * rb_shape_alloc_with_size_pool_index(ID edge_name, rb_shape_t * parent, uint8_t size_pool_index); rb_shape_t * rb_shape_alloc_with_parent_id(ID edge_name, shape_id_t parent_id); +rb_shape_t *rb_shape_traverse_from_new_root(rb_shape_t *initial_shape, rb_shape_t *orig_shape); + bool rb_shape_set_shape_id(VALUE obj, shape_id_t shape_id); VALUE rb_obj_debug_shape(VALUE self, VALUE obj); |