summaryrefslogtreecommitdiff
path: root/regparse.c
diff options
context:
space:
mode:
authoryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2010-12-20 13:22:29 +0000
committeryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2010-12-20 13:22:29 +0000
commit79128855ab1c2cae7fe95b60f89e7bd176f02cc8 (patch)
tree4411aac5d3ca901c91262386c88215317039b5a9 /regparse.c
parentb6e3b715dd11097a8d8d14371a5a90b4c8964d18 (diff)
merges r29803 from trunk into ruby_1_9_2.
-- * regparse.c (and_cclass, or_cclass): fix memory leak. Coverity Scan found this bug. [ruby-dev:42579] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@30256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'regparse.c')
-rw-r--r--regparse.c26
1 files changed, 12 insertions, 14 deletions
diff --git a/regparse.c b/regparse.c
index 2caab909e1..bf40603ddd 100644
--- a/regparse.c
+++ b/regparse.c
@@ -2006,7 +2006,7 @@ and_cclass(CClassNode* dest, CClassNode* cc, ScanEnv* env)
{
OnigEncoding enc = env->enc;
int r, not1, not2;
- BBuf *buf1, *buf2, *pbuf;
+ BBuf *buf1, *buf2, *pbuf = 0;
BitSetRef bsr1, bsr2;
BitSet bs1, bs2;
@@ -2041,17 +2041,16 @@ and_cclass(CClassNode* dest, CClassNode* cc, ScanEnv* env)
else {
r = and_code_range_buf(buf1, not1, buf2, not2, &pbuf, env);
if (r == 0 && not1 != 0) {
- BBuf *tbuf;
+ BBuf *tbuf = 0;
r = not_code_range_buf(enc, pbuf, &tbuf, env);
- if (r != 0) {
- bbuf_free(pbuf);
- return r;
- }
bbuf_free(pbuf);
pbuf = tbuf;
}
}
- if (r != 0) return r;
+ if (r != 0) {
+ bbuf_free(pbuf);
+ return r;
+ }
dest->mbuf = pbuf;
bbuf_free(buf1);
@@ -2065,7 +2064,7 @@ or_cclass(CClassNode* dest, CClassNode* cc, ScanEnv* env)
{
OnigEncoding enc = env->enc;
int r, not1, not2;
- BBuf *buf1, *buf2, *pbuf;
+ BBuf *buf1, *buf2, *pbuf = 0;
BitSetRef bsr1, bsr2;
BitSet bs1, bs2;
@@ -2100,17 +2099,16 @@ or_cclass(CClassNode* dest, CClassNode* cc, ScanEnv* env)
else {
r = or_code_range_buf(enc, buf1, not1, buf2, not2, &pbuf, env);
if (r == 0 && not1 != 0) {
- BBuf *tbuf;
+ BBuf *tbuf = 0;
r = not_code_range_buf(enc, pbuf, &tbuf, env);
- if (r != 0) {
- bbuf_free(pbuf);
- return r;
- }
bbuf_free(pbuf);
pbuf = tbuf;
}
}
- if (r != 0) return r;
+ if (r != 0) {
+ bbuf_free(pbuf);
+ return r;
+ }
dest->mbuf = pbuf;
bbuf_free(buf1);