summaryrefslogtreecommitdiff
path: root/marshal.c
diff options
context:
space:
mode:
authorNAKAMURA Usaku <usa@ruby-lang.org>2021-11-24 19:36:07 +0900
committerNAKAMURA Usaku <usa@ruby-lang.org>2021-11-24 19:36:07 +0900
commit419266d44c54c6b75f1e824f060c8b388f7a405b (patch)
treee3145ee1c653769cc5fe75a6d1ebdad48f1dd8ed /marshal.c
parent61a02168f7ba353a2838f2783f291a816d7e0c90 (diff)
merge revision(s) 89242279e61b023a81c58065c62a82de8829d0b3,529fc204af84f825f98f83c34b004acbaa802615: [Backport #18141]
Marshal.load: do not call the proc until strings have their encoding Ref: https://bugs.ruby-lang.org/issues/18141 --- marshal.c | 7 +++- spec/ruby/core/marshal/shared/load.rb | 62 +++++++++++++++++++++++------------ test/ruby/test_marshal.rb | 17 ++++++++++ 3 files changed, 64 insertions(+), 22 deletions(-) marshal.c: don't call the proc with partially initialized objects. (#4866) For cyclic objects, it requires to keep a st_table of the partially initialized objects. --- marshal.c | 75 ++++++++++++++++++++--------------- spec/ruby/core/marshal/shared/load.rb | 75 ++++++++++++++++++++--------------- test/ruby/test_marshal.rb | 12 ++++++ 3 files changed, 97 insertions(+), 65 deletions(-)
Diffstat (limited to 'marshal.c')
-rw-r--r--marshal.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/marshal.c b/marshal.c
index 8baae8f146..d05b4b9336 100644
--- a/marshal.c
+++ b/marshal.c
@@ -1678,6 +1678,9 @@ r_object0(struct load_arg *arg, int *ivp, VALUE extmod)
v = r_object0(arg, &ivar, extmod);
if (ivar) r_ivar(v, NULL, arg);
+ if (RB_TYPE_P(v, T_STRING)) {
+ v = r_leave(v, arg);
+ }
}
break;
@@ -1805,7 +1808,9 @@ r_object0(struct load_arg *arg, int *ivp, VALUE extmod)
case TYPE_STRING:
v = r_entry(r_string(arg), arg);
- v = r_leave(v, arg);
+ if (!ivp) {
+ v = r_leave(v, arg);
+ }
break;
case TYPE_REGEXP: