diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2020-07-29 00:31:52 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2020-07-30 19:03:18 +0900 |
commit | b2d96abb42abbe2e01f010ffc9ac51f0f9a50002 (patch) | |
tree | 57791da8a71280c335109916376e13f5e0c63af3 /lib/net/http | |
parent | cfbae7dae052180e5dde05a27948ae8d779eccab (diff) |
Extract version number from the source
"requiring version.rb" strategy has some issues.
- cannot work when cross-compiling
- often introduces wrong namespace
- must know the superclasses
- costs at each runtime than at build-time
etc.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3375
Diffstat (limited to 'lib/net/http')
-rw-r--r-- | lib/net/http/net-http.gemspec | 15 | ||||
-rw-r--r-- | lib/net/http/version.rb | 5 |
2 files changed, 9 insertions, 11 deletions
diff --git a/lib/net/http/net-http.gemspec b/lib/net/http/net-http.gemspec index cf3c5bd6a4..c6952c3c1b 100644 --- a/lib/net/http/net-http.gemspec +++ b/lib/net/http/net-http.gemspec @@ -1,12 +1,15 @@ -begin - require_relative "lib/net/http/version" -rescue LoadError # Fallback to load version file in ruby core repository - require_relative "version" +# frozen_string_literal: true + +name = File.basename(__FILE__, ".gemspec") +version = ["lib", Array.new(name.count("-")+1, "..").join("/")].find do |dir| + break File.foreach(File.join(__dir__, dir, "#{name.tr('-', '/')}.rb")) do |line| + /^\s*VERSION\s*=\s*"(.*)"/ =~ line and break $1 + end rescue nil end Gem::Specification.new do |spec| - spec.name = "net-http" - spec.version = Net::Http::VERSION + spec.name = name + spec.version = version spec.authors = ["NARUSE, Yui"] spec.email = ["naruse@airemix.jp"] diff --git a/lib/net/http/version.rb b/lib/net/http/version.rb deleted file mode 100644 index 832d597111..0000000000 --- a/lib/net/http/version.rb +++ /dev/null @@ -1,5 +0,0 @@ -module Net - module Http - VERSION = "0.1.0" - end -end |