summaryrefslogtreecommitdiff
path: root/compile.c
diff options
context:
space:
mode:
authornobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-02-28 23:31:42 +0000
committernobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-02-28 23:31:42 +0000
commit43e41029bf3594353513375d76ba15ded19b0a63 (patch)
treee2c8a4fc074ea26e1d2f2318287fe6d3257d9013 /compile.c
parent9af2ab9d89acb693236e9da58a482551e640e780 (diff)
Revert r61936 "compile.c: use ALLOCV_N"
* compile.c (ibf_dump_object_list): `dump->obj_list` is not fixed yet, as new objects are pushed by lbf_dump_object_object. fixes crash by buffer overflow. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'compile.c')
-rw-r--r--compile.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/compile.c b/compile.c
index ba380ab408..33ffe17e54 100644
--- a/compile.c
+++ b/compile.c
@@ -9334,23 +9334,21 @@ ibf_load_object(const struct ibf_load *load, VALUE object_index)
static void
ibf_dump_object_list(struct ibf_dump *dump, struct ibf_header *header)
{
- VALUE listv;
- ibf_offset_t *list = ALLOCV_N(ibf_offset_t, listv, RARRAY_LEN(dump->obj_list));
+ VALUE list = rb_ary_tmp_new(RARRAY_LEN(dump->obj_list));
int i, size;
for (i=0; i<RARRAY_LEN(dump->obj_list); i++) {
VALUE obj = RARRAY_AREF(dump->obj_list, i);
ibf_offset_t offset = lbf_dump_object_object(dump, obj);
- list[i] = offset;
+ rb_ary_push(list, UINT2NUM(offset));
}
size = i;
header->object_list_offset = ibf_dump_pos(dump);
for (i=0; i<size; i++) {
- ibf_offset_t offset = list[i];
+ ibf_offset_t offset = NUM2UINT(RARRAY_AREF(list, i));
IBF_WV(offset);
}
- ALLOCV_END(listv);
header->object_list_size = size;
}