diff options
author | nagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-08-05 10:59:57 +0000 |
---|---|---|
committer | nagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-08-05 10:59:57 +0000 |
commit | 61cb2958095fe3b05fcec25aea943fa3e06262e6 (patch) | |
tree | b5b285662c21626a6d6e92fbf609af1a80f8a704 | |
parent | fcb4a3d88fa38589239281b1b670b95fba47b277 (diff) |
merge revision(s) 61766: [Backport #14350]
vm_insnhelper.c: search in the indexing order
* vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
search in the indexing order, as well as usual methods.
[ruby-core:84821] [Bug #14350]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | test/ruby/test_array.rb | 12 | ||||
-rw-r--r-- | version.h | 8 | ||||
-rw-r--r-- | vm_insnhelper.c | 18 |
3 files changed, 24 insertions, 14 deletions
diff --git a/test/ruby/test_array.rb b/test/ruby/test_array.rb index 7e63623b7d..955121c0f0 100644 --- a/test/ruby/test_array.rb +++ b/test/ruby/test_array.rb @@ -1631,6 +1631,12 @@ class TestArray < Test::Unit::TestCase ary.min(2) {|a,b| a.length <=> b.length }) assert_equal([13, 14], [20, 32, 32, 21, 30, 25, 29, 13, 14].min(2)) assert_equal([2, 4, 6, 7], [2, 4, 8, 6, 7].min(4)) + + class << (obj = Object.new) + def <=>(x) 1 <=> x end + def coerce(x) [x, 1] end + end + assert_same(obj, [obj, 1.0].min) end def test_max @@ -1646,6 +1652,12 @@ class TestArray < Test::Unit::TestCase assert_equal(%w[albatross horse], ary.max(2) {|a,b| a.length <=> b.length }) assert_equal([3, 2], [0, 0, 0, 0, 0, 0, 1, 3, 2].max(2)) + + class << (obj = Object.new) + def <=>(x) 1 <=> x end + def coerce(x) [x, 1] end + end + assert_same(obj, [obj, 1.0].max) end def test_uniq @@ -1,10 +1,10 @@ #define RUBY_VERSION "2.5.2" -#define RUBY_RELEASE_DATE "2018-07-02" -#define RUBY_PATCHLEVEL 65 +#define RUBY_RELEASE_DATE "2018-08-05" +#define RUBY_PATCHLEVEL 66 #define RUBY_RELEASE_YEAR 2018 -#define RUBY_RELEASE_MONTH 7 -#define RUBY_RELEASE_DAY 2 +#define RUBY_RELEASE_MONTH 8 +#define RUBY_RELEASE_DAY 5 #include "ruby/version.h" diff --git a/vm_insnhelper.c b/vm_insnhelper.c index d4f2c2a00c..0a2eb94753 100644 --- a/vm_insnhelper.c +++ b/vm_insnhelper.c @@ -3186,16 +3186,15 @@ vm_opt_newarray_max(rb_num_t num, const VALUE *ptr) } else { struct cmp_opt_data cmp_opt = { 0, 0 }; - VALUE result = Qundef; + VALUE result = *ptr; rb_num_t i = num - 1; - result = ptr[i]; while (i-- > 0) { - const VALUE v = ptr[i]; - if (result == Qundef || OPTIMIZED_CMP(v, result, cmp_opt) > 0) { + const VALUE v = *++ptr; + if (OPTIMIZED_CMP(v, result, cmp_opt) > 0) { result = v; } } - return result == Qundef ? Qnil : result; + return result; } } else { @@ -3213,16 +3212,15 @@ vm_opt_newarray_min(rb_num_t num, const VALUE *ptr) } else { struct cmp_opt_data cmp_opt = { 0, 0 }; - VALUE result = Qundef; + VALUE result = *ptr; rb_num_t i = num - 1; - result = ptr[i]; while (i-- > 0) { - const VALUE v = ptr[i]; - if (result == Qundef || OPTIMIZED_CMP(v, result, cmp_opt) < 0) { + const VALUE v = *++ptr; + if (OPTIMIZED_CMP(v, result, cmp_opt) < 0) { result = v; } } - return result == Qundef ? Qnil : result; + return result; } } else { |