summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-08-05 06:46:23 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-08-05 06:46:23 +0000
commit23390a82e606ac53a3f9567c98405b19df713feb (patch)
tree4d7a4421ee3ff362fcdc7bf5065de623ffad7040
parent01cfae3beb0b649ca2ae879825349cf0330a3549 (diff)
merge revision(s) 59368: [Backport #13753]
random.c: ensure initialized * random.c (get_rnd, try_get_rnd): ensure initialized to get rid of crash in forked processes. [ruby-core:82100] [Bug #13753] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--random.c4
-rw-r--r--test/ruby/test_rand.rb4
-rw-r--r--version.h2
3 files changed, 7 insertions, 3 deletions
diff --git a/random.c b/random.c
index 6ddf4d186e..6302f8884b 100644
--- a/random.c
+++ b/random.c
@@ -338,7 +338,7 @@ get_rnd(VALUE obj)
{
rb_random_t *ptr;
TypedData_Get_Struct(obj, rb_random_t, &random_data_type, ptr);
- return ptr;
+ return rand_start(ptr);
}
static rb_random_t *
@@ -348,7 +348,7 @@ try_get_rnd(VALUE obj)
return rand_start(&default_rand);
}
if (!rb_typeddata_is_kind_of(obj, &random_data_type)) return NULL;
- return DATA_PTR(obj);
+ return rand_start(DATA_PTR(obj));
}
/* :nodoc: */
diff --git a/test/ruby/test_rand.rb b/test/ruby/test_rand.rb
index 46d10f8386..f204cbc758 100644
--- a/test/ruby/test_rand.rb
+++ b/test/ruby/test_rand.rb
@@ -453,6 +453,10 @@ END
assert_fork_status(1, bug5661) {stable.rand(4)}
r1, r2 = *assert_fork_status(2, bug5661) {stable.rand}
assert_equal(r1, r2, bug5661)
+
+ assert_fork_status(1, '[ruby-core:82100] [Bug #13753]') do
+ Random::DEFAULT.rand(4)
+ end
rescue NotImplementedError
end
diff --git a/version.h b/version.h
index 351e77b375..fde07baf7a 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.4.2"
#define RUBY_RELEASE_DATE "2017-08-05"
-#define RUBY_PATCHLEVEL 179
+#define RUBY_PATCHLEVEL 180
#define RUBY_RELEASE_YEAR 2017
#define RUBY_RELEASE_MONTH 8