summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-22 14:13:40 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-22 14:13:40 +0000
commit10e0fc1b6c8fdc8d275653052e129a2d7569e58b (patch)
tree74cfa6f39d5ff2bef1e10c343c8fced90ff1d1dd
parentb866e34f75a3f4e70282d23fdce68fbc45bfc30e (diff)
merge revision(s) 57688,57689: [Backport #13242]
rational.c: infinity in power * rational.c (nurat_expt): return Infinity due to overflow. [ruby-core:79686] [Bug #13242]: rational.c: infinity in power * rational.c (nurat_expt): return 0 due to overflow. [ruby-core:79686] [Bug #13242]: git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--numeric.c2
-rw-r--r--rational.c8
-rw-r--r--test/ruby/test_rational.rb8
-rw-r--r--version.h2
4 files changed, 19 insertions, 1 deletions
diff --git a/numeric.c b/numeric.c
index 46f112349f..ca961d8d6c 100644
--- a/numeric.c
+++ b/numeric.c
@@ -3243,6 +3243,8 @@ int_pow(long x, unsigned long y)
VALUE v;
bignum:
v = rb_big_pow(rb_int2big(x), LONG2NUM(y));
+ if (RB_FLOAT_TYPE_P(v)) /* infinity due to overflow */
+ return v;
if (z != 1) v = rb_big_mul(rb_int2big(neg ? -z : z), v);
return v;
}
diff --git a/rational.c b/rational.c
index 7f3a06af80..6b248e3483 100644
--- a/rational.c
+++ b/rational.c
@@ -1038,6 +1038,14 @@ nurat_expt(VALUE self, VALUE other)
den = ONE;
break;
}
+ if (RB_FLOAT_TYPE_P(num)) { /* infinity due to overflow */
+ if (RB_FLOAT_TYPE_P(den)) return DBL2NUM(NAN);
+ return num;
+ }
+ if (RB_FLOAT_TYPE_P(den)) { /* infinity due to overflow */
+ num = ZERO;
+ den = ONE;
+ }
return f_rational_new2(CLASS_OF(self), num, den);
}
}
diff --git a/test/ruby/test_rational.rb b/test/ruby/test_rational.rb
index ea51ca29f0..ccef384d94 100644
--- a/test/ruby/test_rational.rb
+++ b/test/ruby/test_rational.rb
@@ -927,6 +927,14 @@ class Rational_Test < Test::Unit::TestCase
assert_raise(ZeroDivisionError, bug5713) { Rational(0, 1) ** Rational(-2,3) }
end
+ def test_power_overflow
+ bug = '[ruby-core:79686] [Bug #13242]: Infinity due to overflow'
+ x = EnvUtil.suppress_warning {4r**40000000}
+ assert_predicate x, :infinite?, bug
+ x = EnvUtil.suppress_warning {(1/4r)**40000000}
+ assert_equal 0, x, bug
+ end
+
def test_positive_p
assert_predicate(1/2r, :positive?)
assert_not_predicate(-1/2r, :positive?)
diff --git a/version.h b/version.h
index 82a0fdc0e6..07f9dcfe67 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.3.3"
#define RUBY_RELEASE_DATE "2017-03-22"
-#define RUBY_PATCHLEVEL 257
+#define RUBY_PATCHLEVEL 258
#define RUBY_RELEASE_YEAR 2017
#define RUBY_RELEASE_MONTH 3