summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-11-30 12:34:23 +0000
committerusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-11-30 12:34:23 +0000
commit99bcf86ec38aee035706a0dce1990dc4b1aba31f (patch)
tree962bfc43098ffc0dc38e181f72e8bd1ca926e1f6
parent7caf8a508f63d6186d42a820d1bf6b4daa661a04 (diff)
merge revision(s) 50737: [Backport #11211]
* insns.def (defined): skip respond_to_missing? when a method is available. [Bug #11211] * test/ruby/test_defined.rb: add a test for this fix. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog8
-rw-r--r--insns.def11
-rw-r--r--test/ruby/test_defined.rb25
-rw-r--r--version.h2
4 files changed, 38 insertions, 8 deletions
diff --git a/ChangeLog b/ChangeLog
index 626ac2d8a8..76b61caab8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+Mon Nov 30 21:29:57 2015 Koichi Sasada <ko1@atdot.net>
+
+ * insns.def (defined): skip respond_to_missing? when
+ a method is available.
+ [Bug #11211]
+
+ * test/ruby/test_defined.rb: add a test for this fix.
+
Mon Nov 30 21:27:09 2015 NAKAMURA Usaku <usa@ruby-lang.org>
* ext/digest/rmd160/rmd160.c: fixed commit mistake at r52797.
diff --git a/insns.def b/insns.def
index ad4bba6912..5a9c11ee79 100644
--- a/insns.def
+++ b/insns.def
@@ -738,15 +738,12 @@ defined
const rb_method_entry_t *me = rb_method_entry(klass, SYM2ID(obj), 0);
if (me) {
- if (!(me->flag & NOEX_PRIVATE)) {
- if (!((me->flag & NOEX_PROTECTED) &&
- !rb_obj_is_kind_of(GET_SELF(),
- rb_class_real(klass)))) {
- expr_type = DEFINED_METHOD;
- }
+ if (!(me->flag & NOEX_PRIVATE) &&
+ !((me->flag & NOEX_PROTECTED) && !rb_obj_is_kind_of(GET_SELF(), rb_class_real(klass)))) {
+ expr_type = DEFINED_METHOD;
}
}
- {
+ else {
VALUE args[2];
VALUE r;
diff --git a/test/ruby/test_defined.rb b/test/ruby/test_defined.rb
index 6c63c7fb27..fdae6789f1 100644
--- a/test/ruby/test_defined.rb
+++ b/test/ruby/test_defined.rb
@@ -209,4 +209,29 @@ class TestDefined < Test::Unit::TestCase
def test_super_toplevel
assert_separately([], "assert_nil(defined?(super))")
end
+
+ class ExampleRespondToMissing
+ attr_reader :called
+
+ def initialize
+ @called = false
+ end
+
+ def respond_to_missing? *args
+ @called = true
+ false
+ end
+
+ def existing_method
+ end
+ end
+
+ def test_method_by_respond_to_missing
+ bug_11211 = '[Bug #11211]'
+ obj = ExampleRespondToMissing.new
+ assert_equal("method", defined?(obj.existing_method), bug_11211)
+ assert_equal(false, obj.called, bug_11211)
+ assert_equal(nil, defined?(obj.non_existing_method), bug_11211)
+ assert_equal(true, obj.called, bug_11211)
+ end
end
diff --git a/version.h b/version.h
index 929ccf63bc..600347d66b 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.1.8"
#define RUBY_RELEASE_DATE "2015-11-30"
-#define RUBY_PATCHLEVEL 427
+#define RUBY_PATCHLEVEL 428
#define RUBY_RELEASE_YEAR 2015
#define RUBY_RELEASE_MONTH 11