summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2014-02-05 14:53:48 +0000
committernaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2014-02-05 14:53:48 +0000
commit72d18038d914e7c2e383f09bae5e5bd7b06721a8 (patch)
tree5a980623b74ec78d937bc5271825c3fbf2e747fe
parente7a2c4251e98cd515d861facbba2fa86983dfb89 (diff)
merge revision(s) 44525,44534,44537: [Backport #9381]
* hash.c (rb_objid_hash): return hash value from object ID with a salt, extract from rb_any_hash(). * object.c (rb_obj_hash): return same value as rb_any_hash(). fix r44125. [ruby-core:59638] [Bug #9381] * hash.c (rb_any_hash): should treat the return value of rb_objid_hash() as `long', because ruby assumes the object id of an object is `long'. this fixes test failures on mswin64 introduced at r44525. * hash.c (rb_objid_hash): should return `long'. brushup r44534. * object.c (rb_obj_hash): follow above change. as `long', because ruby assumes the hash value of the object id of an object is `long'. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@44846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog21
-rw-r--r--hash.c15
-rw-r--r--object.c4
-rw-r--r--test/ruby/test_hash.rb21
-rw-r--r--version.h2
5 files changed, 57 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 922bdcafdd..d8a73d3aec 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,24 @@
+Wed Feb 5 23:43:30 2014 NAKAMURA Usaku <usa@ruby-lang.org>
+
+ * hash.c (rb_objid_hash): should return `long'. brushup r44534.
+
+ * object.c (rb_obj_hash): follow above change.
+
+Wed Feb 5 23:43:30 2014 NAKAMURA Usaku <usa@ruby-lang.org>
+
+ * hash.c (rb_any_hash): should treat the return value of rb_objid_hash()
+ as `long', because ruby assumes the hash value of the object id of
+ an object is `long'.
+ this fixes test failures on mswin64 introduced at r44525.
+
+Wed Feb 5 23:43:30 2014 Nobuyoshi Nakada <nobu@ruby-lang.org>
+
+ * hash.c (rb_objid_hash): return hash value from object ID with a
+ salt, extract from rb_any_hash().
+
+ * object.c (rb_obj_hash): return same value as rb_any_hash().
+ fix r44125. [ruby-core:59638] [Bug #9381]
+
Wed Feb 5 22:28:41 2014 Nobuyoshi Nakada <nobu@ruby-lang.org>
* vm_insnhelper.c (vm_search_super_method): allow bound method from a
diff --git a/hash.c b/hash.c
index 0cbc46baf5..1c285c2b23 100644
--- a/hash.c
+++ b/hash.c
@@ -123,6 +123,8 @@ rb_hash(VALUE obj)
return hval;
}
+long rb_objid_hash(st_index_t index);
+
static st_index_t
rb_any_hash(VALUE a)
{
@@ -131,9 +133,7 @@ rb_any_hash(VALUE a)
if (SPECIAL_CONST_P(a)) {
if (a == Qundef) return 0;
- hnum = rb_hash_start((st_index_t)a);
- hnum = rb_hash_uint(hnum, (st_index_t)rb_any_hash);
- hnum = rb_hash_end(hnum);
+ hnum = rb_objid_hash((st_index_t)a);
}
else if (BUILTIN_TYPE(a) == T_STRING) {
hnum = rb_str_hash(a);
@@ -146,6 +146,15 @@ rb_any_hash(VALUE a)
return (st_index_t)RSHIFT(hnum, 1);
}
+long
+rb_objid_hash(st_index_t index)
+{
+ st_index_t hnum = rb_hash_start(index);
+ hnum = rb_hash_uint(hnum, (st_index_t)rb_any_hash);
+ hnum = rb_hash_end(hnum);
+ return hnum;
+}
+
static const struct st_hash_type objhash = {
rb_any_cmp,
rb_any_hash,
diff --git a/object.c b/object.c
index 466ec75492..bb43b4617e 100644
--- a/object.c
+++ b/object.c
@@ -161,6 +161,7 @@ rb_obj_equal(VALUE obj1, VALUE obj2)
VALUE
rb_obj_hash(VALUE obj)
{
+ long rb_objid_hash(st_index_t index);
VALUE oid = rb_obj_id(obj);
#if SIZEOF_LONG == SIZEOF_VOIDP
st_index_t index = NUM2LONG(oid);
@@ -169,8 +170,7 @@ rb_obj_hash(VALUE obj)
#else
# error not supported
#endif
- st_index_t h = rb_hash_end(rb_hash_start(index));
- return LONG2FIX(h);
+ return LONG2FIX(rb_objid_hash(index));
}
/*
diff --git a/test/ruby/test_hash.rb b/test/ruby/test_hash.rb
index 910da9374a..c872b11a3c 100644
--- a/test/ruby/test_hash.rb
+++ b/test/ruby/test_hash.rb
@@ -1228,6 +1228,27 @@ class TestHash < Test::Unit::TestCase
assert_no_memory_leak([], prepare, code, bug9187)
end
+ def test_wrapper_of_special_const
+ bug9381 = '[ruby-core:59638] [Bug #9381]'
+
+ wrapper = Class.new do
+ def initialize(obj)
+ @obj = obj
+ end
+
+ def hash
+ @obj.hash
+ end
+
+ def eql?(other)
+ @obj.eql?(other)
+ end
+ end
+
+ hash = {5 => bug9381}
+ assert_equal(bug9381, hash[wrapper.new(5)])
+ end
+
class TestSubHash < TestHash
class SubHash < Hash
def reject(*)
diff --git a/version.h b/version.h
index 0e69916f3c..7b9f857e61 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.1.1"
#define RUBY_RELEASE_DATE "2014-02-05"
-#define RUBY_PATCHLEVEL 21
+#define RUBY_PATCHLEVEL 22
#define RUBY_RELEASE_YEAR 2014
#define RUBY_RELEASE_MONTH 2