summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Kokubun <takashikkbn@gmail.com>2021-05-31 21:12:27 -0700
committerTakashi Kokubun <takashikkbn@gmail.com>2021-05-31 21:12:48 -0700
commit07c05b6fe931337e928a89ac5ebf654862dc0eca (patch)
treede5c5b7206022ae0cac622d4744f296a2f99ae41
parentc9ab8fe2b12652db7f66b71b03248a6387e378fe (diff)
Drop JIT_ISEQ_SIZE_THRESHOLD
Compiling everything seems to contributed to improving the final performance in general. MJIT's compilation is slow anyway, especially when you need to wait for JIT compaction. This might make sense for short-time benchmarks like Optcarrot with default parameters, but it didn't give benefits in my local environment.
-rw-r--r--mjit.c3
-rw-r--r--mjit.h4
2 files changed, 1 insertions, 6 deletions
diff --git a/mjit.c b/mjit.c
index 2ee9225cf7..e1eb913aba 100644
--- a/mjit.c
+++ b/mjit.c
@@ -250,8 +250,7 @@ static inline int
mjit_target_iseq_p(struct rb_iseq_constant_body *body)
{
return (body->type == ISEQ_TYPE_METHOD || body->type == ISEQ_TYPE_BLOCK)
- && !body->builtin_inline_p
- && body->iseq_size < JIT_ISEQ_SIZE_THRESHOLD;
+ && !body->builtin_inline_p;
}
static void
diff --git a/mjit.h b/mjit.h
index 986a3adb92..8cfc3d05b7 100644
--- a/mjit.h
+++ b/mjit.h
@@ -101,10 +101,6 @@ extern struct mjit_cont *mjit_cont_new(rb_execution_context_t *ec);
extern void mjit_cont_free(struct mjit_cont *cont);
extern void mjit_mark_cc_entries(const struct rb_iseq_constant_body *const body);
-// A threshold used to reject long iseqs from JITting as such iseqs
-// takes too much time to be compiled.
-#define JIT_ISEQ_SIZE_THRESHOLD 1000
-
# ifdef MJIT_HEADER
NOINLINE(static COLDFUNC VALUE mjit_exec_slowpath(rb_execution_context_t *ec, const rb_iseq_t *iseq, struct rb_iseq_constant_body *body));
# else