summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-31 10:59:53 +0000
committerusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-31 10:59:53 +0000
commit3d89e55ba384dc065c7f76e0bac2350c4606109b (patch)
treecee5e81e3951c9d1761773587aa585468d9997e7
parentc7dfe6077fbc61ee396e67f89bf566298dbdc3e7 (diff)
merge revision(s) 65974: [Backport #15340]
Normalize month-mday before finding epoch Especially over the year 2038, 30 Feb and so on may cause odd behavior on validating found epoch with given year-month-day [Bug #15340] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@66967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--test/ruby/test_time.rb23
-rw-r--r--time.c23
-rw-r--r--version.h2
3 files changed, 47 insertions, 1 deletions
diff --git a/test/ruby/test_time.rb b/test/ruby/test_time.rb
index d3a8645024..2900f00b78 100644
--- a/test/ruby/test_time.rb
+++ b/test/ruby/test_time.rb
@@ -1043,6 +1043,29 @@ class TestTime < Test::Unit::TestCase
assert_equal(min, t.min)
assert_equal(sec, t.sec)
}
+ assert_equal(Time.local(2038,3,1), Time.local(2038,2,29))
+ assert_equal(Time.local(2038,3,2), Time.local(2038,2,30))
+ assert_equal(Time.local(2038,3,3), Time.local(2038,2,31))
+ assert_equal(Time.local(2040,2,29), Time.local(2040,2,29))
+ assert_equal(Time.local(2040,3,1), Time.local(2040,2,30))
+ assert_equal(Time.local(2040,3,2), Time.local(2040,2,31))
+ n = 2 ** 64
+ n += 400 - n % 400 # n is over 2^64 and multiple of 400
+ assert_equal(Time.local(n,2,29),Time.local(n,2,29))
+ assert_equal(Time.local(n,3,1), Time.local(n,2,30))
+ assert_equal(Time.local(n,3,2), Time.local(n,2,31))
+ n += 100
+ assert_equal(Time.local(n,3,1), Time.local(n,2,29))
+ assert_equal(Time.local(n,3,2), Time.local(n,2,30))
+ assert_equal(Time.local(n,3,3), Time.local(n,2,31))
+ n += 4
+ assert_equal(Time.local(n,2,29),Time.local(n,2,29))
+ assert_equal(Time.local(n,3,1), Time.local(n,2,30))
+ assert_equal(Time.local(n,3,2), Time.local(n,2,31))
+ n += 1
+ assert_equal(Time.local(n,3,1), Time.local(n,2,29))
+ assert_equal(Time.local(n,3,2), Time.local(n,2,30))
+ assert_equal(Time.local(n,3,3), Time.local(n,2,31))
end
def test_future
diff --git a/time.c b/time.c
index d167756b18..088c9c84cd 100644
--- a/time.c
+++ b/time.c
@@ -2574,6 +2574,29 @@ time_arg(int argc, VALUE *argv, struct vtm *vtm)
vtm->mday = obj2ubits(v[2], 5);
}
+ /* normalize month-mday */
+ switch (vtm->mon) {
+ case 2:
+ {
+ /* this drops higher bits but it's not a problem to calc leap year */
+ unsigned int mday2 = leap_year_v_p(vtm->year) ? 29 : 28;
+ if (vtm->mday > mday2) {
+ vtm->mday -= mday2;
+ vtm->mon++;
+ }
+ }
+ break;
+ case 4:
+ case 6:
+ case 9:
+ case 11:
+ if (vtm->mday == 31) {
+ vtm->mon++;
+ vtm->mday = 1;
+ }
+ break;
+ }
+
vtm->hour = NIL_P(v[3])?0:obj2ubits(v[3], 5);
vtm->min = NIL_P(v[4])?0:obj2ubits(v[4], 6);
diff --git a/version.h b/version.h
index e1ec97a685..506befeb0a 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.4.6"
#define RUBY_RELEASE_DATE "2019-01-31"
-#define RUBY_PATCHLEVEL 342
+#define RUBY_PATCHLEVEL 343
#define RUBY_RELEASE_YEAR 2019
#define RUBY_RELEASE_MONTH 1