summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2013-09-12 15:54:50 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2013-09-12 15:54:50 +0000
commit3041c43df15bd895c41860930332579b80f7d68e (patch)
treeaaf0cfff494ec6559b4be52aa4dba392f417483a
parentba76a79a3eeba71cc3d6ea952521e42415b025a6 (diff)
merge revision(s) 42869: [Backport #8872]
* vm_eval.c (vm_call0): fix prototype, the id parameter should be of type ID, not VALUE * vm_insnhelper.c (check_match): the rb_funcall family of functions does not care about refinements. We need to use rb_method_entry_with_refinements instead to call === with refinements. Thanks to Jon Conley for reporting this bug. [ruby-core:57051] [Bug #8872] * test/ruby/test_refinement.rb: add test git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@42923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog13
-rw-r--r--test/ruby/test_refinement.rb21
-rw-r--r--version.h2
-rw-r--r--vm_eval.c2
-rw-r--r--vm_insnhelper.c13
5 files changed, 45 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 7212ba108b..d25ab986b3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+Fri Sep 13 00:33:09 2013 Charlie Somerville <charliesome@ruby-lang.org>
+
+ * vm_eval.c (vm_call0): fix prototype, the id parameter should be of
+ type ID, not VALUE
+
+ * vm_insnhelper.c (check_match): the rb_funcall family of functions
+ does not care about refinements. We need to use
+ rb_method_entry_with_refinements instead to call === with
+ refinements. Thanks to Jon Conley for reporting this bug.
+ [ruby-core:57051] [Bug #8872]
+
+ * test/ruby/test_refinement.rb: add test
+
Fri Sep 13 00:18:55 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
* enumerator.c (lazy_zip_func): fix non-single argument. fix
diff --git a/test/ruby/test_refinement.rb b/test/ruby/test_refinement.rb
index 23b73667a7..b6bdc9430f 100644
--- a/test/ruby/test_refinement.rb
+++ b/test/ruby/test_refinement.rb
@@ -826,6 +826,27 @@ class TestRefinement < Test::Unit::TestCase
assert_equal([:foo, :ref, bug7925], x, bug7925)
end
+ def test_case_dispatch_is_aware_of_refinements
+ assert_in_out_err([], <<-RUBY, ["refinement used"], ["-:2: warning: Refinements are experimental, and the behavior may change in future versions of Ruby!"])
+ module RefineSymbol
+ refine Symbol do
+ def ===(other)
+ true
+ end
+ end
+ end
+
+ using RefineSymbol
+
+ case :a
+ when :b
+ puts "refinement used"
+ else
+ puts "refinement not used"
+ end
+ RUBY
+ end
+
private
def eval_using(mod, s)
diff --git a/version.h b/version.h
index a1271f91a0..ddf4a211fe 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.0.0"
#define RUBY_RELEASE_DATE "2013-09-13"
-#define RUBY_PATCHLEVEL 305
+#define RUBY_PATCHLEVEL 306
#define RUBY_RELEASE_YEAR 2013
#define RUBY_RELEASE_MONTH 9
diff --git a/vm_eval.c b/vm_eval.c
index 10dadaf41e..88f05ebe4f 100644
--- a/vm_eval.c
+++ b/vm_eval.c
@@ -34,7 +34,7 @@ static VALUE send_internal(int argc, const VALUE *argv, VALUE recv, call_type sc
static VALUE vm_call0_body(rb_thread_t* th, rb_call_info_t *ci, const VALUE *argv);
static VALUE
-vm_call0(rb_thread_t* th, VALUE recv, VALUE id, int argc, const VALUE *argv,
+vm_call0(rb_thread_t* th, VALUE recv, ID id, int argc, const VALUE *argv,
const rb_method_entry_t *me, VALUE defined_class)
{
rb_call_info_t ci_entry, *ci = &ci_entry;
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
index 500b2b5594..db8591a812 100644
--- a/vm_insnhelper.c
+++ b/vm_insnhelper.c
@@ -919,18 +919,23 @@ opt_eq_func(VALUE recv, VALUE obj, CALL_INFO ci)
}
static VALUE
+vm_call0(rb_thread_t*, VALUE, ID, int, const VALUE*, const rb_method_entry_t*, VALUE);
+
+static VALUE
check_match(VALUE pattern, VALUE target, enum vm_check_match_type type)
{
switch (type) {
case VM_CHECKMATCH_TYPE_WHEN:
return pattern;
- case VM_CHECKMATCH_TYPE_CASE:
- return rb_funcall2(pattern, idEqq, 1, &target);
- case VM_CHECKMATCH_TYPE_RESCUE: {
+ case VM_CHECKMATCH_TYPE_RESCUE:
if (!rb_obj_is_kind_of(pattern, rb_cModule)) {
rb_raise(rb_eTypeError, "class or module required for rescue clause");
}
- return RTEST(rb_funcall2(pattern, idEqq, 1, &target));
+ /* fall through */
+ case VM_CHECKMATCH_TYPE_CASE: {
+ VALUE defined_class;
+ rb_method_entry_t *me = rb_method_entry_with_refinements(CLASS_OF(pattern), idEqq, &defined_class);
+ return vm_call0(GET_THREAD(), pattern, idEqq, 1, &target, me, defined_class);
}
default:
rb_bug("check_match: unreachable");