diff options
author | usa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2012-12-21 15:37:01 +0000 |
---|---|---|
committer | usa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2012-12-21 15:37:01 +0000 |
commit | 29ff037211ba5a7516931d691cb6cc33f77ca6a9 (patch) | |
tree | 90e5224d6b650b76ff32e87f731c1d9f07226b2e | |
parent | 2b2ccf4235296dde3fdbbe0e2519d1e6ea4ef3ea (diff) |
merge revision(s) 38493,38539: [Backport #7454]
* gc.c (nonspecial_obj_id): VALUE is not compatible with Fixnum on
LLP64 platform, such as 64bit Windows.
reporeted by Heesob Park at [ruby-core:50255] [Bug #7454], and the
fix is suggested by akr.
* object.c (rb_obj_hash): shouldn't assume object_id can be long.
based on a patch by Heesob Park at [ruby-core:51060].
cf. [Backport #7454]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@38541 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 13 | ||||
-rw-r--r-- | gc.c | 10 | ||||
-rw-r--r-- | object.c | 9 | ||||
-rw-r--r-- | version.h | 6 |
4 files changed, 33 insertions, 5 deletions
@@ -1,3 +1,16 @@ +Sat Dec 22 00:33:28 2012 NAKAMURA Usaku <usa@ruby-lang.org> + + * object.c (rb_obj_hash): shouldn't assume object_id can be long. + based on a patch by Heesob Park at [ruby-core:51060]. + cf. [Backport #7454] + +Sat Dec 22 00:33:28 2012 NAKAMURA Usaku <usa@ruby-lang.org> + + * gc.c (nonspecial_obj_id): VALUE is not compatible with Fixnum on + LLP64 platform, such as 64bit Windows. + reporeted by Heesob Park at [ruby-core:50255] [Bug #7454], and the + fix is suggested by akr. + Fri Dec 21 16:03:54 2012 NAKAMURA Usaku <usa@ruby-lang.org> * test/ruby/test_argf.rb (TestArgf#test_chars): since marshal data is @@ -99,6 +99,14 @@ ruby_gc_params_t initial_params = { #define nomem_error GET_VM()->special_exceptions[ruby_error_nomemory] +#if SIZEOF_LONG == SIZEOF_VOIDP +# define nonspecial_obj_id(obj) (VALUE)((SIGNED_VALUE)(obj)|FIXNUM_FLAG) +#elif SIZEOF_LONG_LONG == SIZEOF_VOIDP +# define nonspecial_obj_id(obj) LL2NUM((SIGNED_VALUE)(obj) / 2) +#else +# error not supported +#endif + int ruby_gc_debug_indent = 0; /* for GC profile */ @@ -3283,7 +3291,7 @@ rb_obj_id(VALUE obj) if (SPECIAL_CONST_P(obj)) { return LONG2NUM((SIGNED_VALUE)obj); } - return (VALUE)((SIGNED_VALUE)obj|FIXNUM_FLAG); + return nonspecial_obj_id(obj); } static int @@ -112,7 +112,14 @@ VALUE rb_obj_hash(VALUE obj) { VALUE oid = rb_obj_id(obj); - st_index_t h = rb_hash_end(rb_hash_start(NUM2LONG(oid))); +#if SIZEOF_LONG == SIZEOF_VOIDP + st_index_t index = NUM2LONG(oid); +#elif SIZEOF_LONG_LONG == SIZEOF_VOIDP + st_index_t index = NUM2LL(oid); +#else +# error not supported +#endif + st_index_t h = rb_hash_end(rb_hash_start(index)); return LONG2FIX(h); } @@ -1,10 +1,10 @@ #define RUBY_VERSION "1.9.3" -#define RUBY_PATCHLEVEL 357 +#define RUBY_PATCHLEVEL 358 -#define RUBY_RELEASE_DATE "2012-12-21" +#define RUBY_RELEASE_DATE "2012-12-22" #define RUBY_RELEASE_YEAR 2012 #define RUBY_RELEASE_MONTH 12 -#define RUBY_RELEASE_DAY 21 +#define RUBY_RELEASE_DAY 22 #include "ruby/version.h" |