summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2012-02-24 14:49:51 +0000
committernaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2012-02-24 14:49:51 +0000
commit76dc4b9a24863717e7b4f722105eec044f85801b (patch)
treedae155e7d2eb0991e88c51f1fbe68dc21e801490
parentb329509a08d9d9226e6fd3f54c79c84837cb9485 (diff)
merge revision(s) 34755:
* lib/ostruct.rb (delete_field): Bug fix so previous value is returned. Patch by Nick Recobra [Bug #6063] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog5
-rw-r--r--lib/ostruct.rb2
-rw-r--r--test/ostruct/test_ostruct.rb3
-rw-r--r--version.h2
4 files changed, 9 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index c66a17c007..d417dd2dad 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Fri Feb 24 23:49:05 2012 Marc-Andre Lafortune <ruby-core@marc-andre.ca>
+
+ * lib/ostruct.rb (delete_field): Bug fix so previous value is
+ returned. Patch by Nick Recobra [Bug #6063]
+
Fri Feb 24 08:53:28 2012 Nobuyoshi Nakada <nobu@ruby-lang.org>
* parse.y (parser_tokadd_string, parser_yylex): insert a backslash
diff --git a/lib/ostruct.rb b/lib/ostruct.rb
index a57eb08e7c..a4c0d55d09 100644
--- a/lib/ostruct.rb
+++ b/lib/ostruct.rb
@@ -189,8 +189,8 @@ class OpenStruct
#
def delete_field(name)
sym = name.to_sym
- @table.delete sym
singleton_class.__send__(:remove_method, sym, "#{name}=")
+ @table.delete sym
end
InspectKey = :__inspect_key__ # :nodoc:
diff --git a/test/ostruct/test_ostruct.rb b/test/ostruct/test_ostruct.rb
index db8e7415eb..dca2382b2b 100644
--- a/test/ostruct/test_ostruct.rb
+++ b/test/ostruct/test_ostruct.rb
@@ -57,9 +57,10 @@ class TC_OpenStruct < Test::Unit::TestCase
o.a = 'a'
assert_respond_to(o, :a)
assert_respond_to(o, :a=)
- o.delete_field :a
+ a = o.delete_field :a
assert_not_respond_to(o, :a, bug)
assert_not_respond_to(o, :a=, bug)
+ assert_equal(a, 'a')
end
def test_method_missing_handles_square_bracket_equals
diff --git a/version.h b/version.h
index 47bacd55ac..5ae8780b2d 100644
--- a/version.h
+++ b/version.h
@@ -1,5 +1,5 @@
#define RUBY_VERSION "1.9.3"
-#define RUBY_PATCHLEVEL 142
+#define RUBY_PATCHLEVEL 143
#define RUBY_RELEASE_DATE "2012-02-24"
#define RUBY_RELEASE_YEAR 2012