summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2016-03-08 18:34:58 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2016-03-08 18:34:58 +0000
commiteb71255350e23a3050009bdd411657b6f485d806 (patch)
treef3584ad624406726d20b32bf191bf06cb472c42b
parent782b9a89380c80ba4eb2276b4974e25a3b329921 (diff)
merge revision(s) 53167: [Backport #11825]
* re.c (reg_names_iter): should consider encoding of regexp. [ruby-core:72185] [Bug #11825] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@54036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog5
-rw-r--r--re.c2
-rw-r--r--test/ruby/test_regexp.rb6
-rw-r--r--version.h8
4 files changed, 16 insertions, 5 deletions
diff --git a/ChangeLog b/ChangeLog
index 4ba55c7041..cbf36d8c44 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Mar 9 03:34:54 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
+
+ * re.c (reg_names_iter): should consider encoding of regexp.
+ [ruby-core:72185] [Bug #11825]
+
Wed Feb 24 08:18:18 2016 Naohisa Goto <ngotogenome@gmail.com>
* enc/windows_1250.c: Should not use C++ style comments (C99 feature).
diff --git a/re.c b/re.c
index b2bcda5cae..6355ad0a7b 100644
--- a/re.c
+++ b/re.c
@@ -757,7 +757,7 @@ reg_names_iter(const OnigUChar *name, const OnigUChar *name_end,
int back_num, int *back_refs, OnigRegex regex, void *arg)
{
VALUE ary = (VALUE)arg;
- rb_ary_push(ary, rb_str_new((const char *)name, name_end-name));
+ rb_ary_push(ary, rb_enc_str_new((const char *)name, name_end-name, regex->enc));
return 0;
}
diff --git a/test/ruby/test_regexp.rb b/test/ruby/test_regexp.rb
index cef21b99aa..0c88670eb8 100644
--- a/test/ruby/test_regexp.rb
+++ b/test/ruby/test_regexp.rb
@@ -118,13 +118,19 @@ class TestRegexp < Test::Unit::TestCase
assert_equal(nil, Regexp.last_match(1))
assert_equal(nil, Regexp.last_match(:foo))
+ bug11825_name = "\u{5b9d 77f3}"
+ bug11825_str = "\u{30eb 30d3 30fc}"
+ bug11825_re = /(?<#{bug11825_name}>)#{bug11825_str}/
+
assert_equal(["foo", "bar"], /(?<foo>.)(?<bar>.)/.names)
assert_equal(["foo"], /(?<foo>.)(?<foo>.)/.names)
assert_equal([], /(.)(.)/.names)
+ assert_equal([bug11825_name], bug11825_re.names)
assert_equal(["foo", "bar"], /(?<foo>.)(?<bar>.)/.match("ab").names)
assert_equal(["foo"], /(?<foo>.)(?<foo>.)/.match("ab").names)
assert_equal([], /(.)(.)/.match("ab").names)
+ assert_equal([bug11825_name], bug11825_re.match(bug11825_str).names)
assert_equal({"foo"=>[1], "bar"=>[2]},
/(?<foo>.)(?<bar>.)/.named_captures)
diff --git a/version.h b/version.h
index 4d5ed73a49..972e1b816b 100644
--- a/version.h
+++ b/version.h
@@ -1,10 +1,10 @@
#define RUBY_VERSION "2.2.5"
-#define RUBY_RELEASE_DATE "2016-02-24"
-#define RUBY_PATCHLEVEL 241
+#define RUBY_RELEASE_DATE "2016-03-09"
+#define RUBY_PATCHLEVEL 242
#define RUBY_RELEASE_YEAR 2016
-#define RUBY_RELEASE_MONTH 2
-#define RUBY_RELEASE_DAY 24
+#define RUBY_RELEASE_MONTH 3
+#define RUBY_RELEASE_DAY 9
#include "ruby/version.h"