summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2009-03-03 11:40:32 +0000
committeryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2009-03-03 11:40:32 +0000
commit5665cf676f2587af86be584126453cd7f5880758 (patch)
tree53c3191835e1c64760d3bb7ab9eaeb6829a1d6bd
parentc18695771d2e985008f3823f2e8e36e7bfdff985 (diff)
merges r22608 from trunk into ruby_1_9_1.
-- * string.c (rb_str_chomp_bang): coderange may change. [ruby-core:22414] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_1@22739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog5
-rw-r--r--string.c2
-rw-r--r--test/ruby/test_string.rb4
3 files changed, 10 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 790bef05af..6761aa400b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Feb 25 02:28:51 2009 Nobuyoshi Nakada <nobu@ruby-lang.org>
+
+ * string.c (rb_str_chomp_bang): coderange may change.
+ [ruby-core:22414]
+
Wed Feb 25 02:17:30 2009 Nobuyoshi Nakada <nobu@ruby-lang.org>
* string.c (rb_str_delete_bang): should recalculate coderange.
diff --git a/string.c b/string.c
index 452bc6ad0f..35991bb7ef 100644
--- a/string.c
+++ b/string.c
@@ -5947,7 +5947,7 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
memcmp(RSTRING_PTR(rs), pp, rslen) == 0)) {
if (rb_enc_left_char_head(p, pp, e, enc) != pp)
return Qnil;
- str_modify_keep_cr(str);
+ rb_str_modify(str);
STR_SET_LEN(str, RSTRING_LEN(str) - rslen);
RSTRING_PTR(str)[RSTRING_LEN(str)] = '\0';
return str;
diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb
index a7a2bba0b4..f3aa45a737 100644
--- a/test/ruby/test_string.rb
+++ b/test/ruby/test_string.rb
@@ -339,6 +339,8 @@ class TestString < Test::Unit::TestCase
assert_equal(S("hello"), S("hello").chomp)
assert_equal(S("hello"), S("hello!").chomp)
$/ = save
+
+ assert_equal(S("a").hash, S("a\u0101").chomp(S("\u0101")).hash, '[ruby-core:22414]')
end
def test_chomp!
@@ -393,6 +395,8 @@ class TestString < Test::Unit::TestCase
s = "foo\r"
s.chomp!("")
assert_equal("foo\r", s)
+
+ assert_equal(S("a").hash, S("a\u0101").chomp!(S("\u0101")).hash, '[ruby-core:22414]')
end
def test_chop