diff options
| author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2023-03-03 11:07:36 +0900 |
|---|---|---|
| committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2023-03-03 15:27:37 +0900 |
| commit | 680bd9027f8cb7977bbc216609db2f4e3cf199a8 (patch) | |
| tree | 80354a5fea856f47a8bc2e1b82141a66dffd7e78 | |
| parent | 103a65316c103253059ca4c49359dc7eb0043a4d (diff) | |
[Bug #19471] `Regexp.compile` should handle keyword arguments
As well as `Regexp.new`, it should pass keyword arguments to the
`Regexp#initialize` method.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/7431
| -rw-r--r-- | re.c | 2 | ||||
| -rw-r--r-- | test/ruby/test_regexp.rb | 5 |
2 files changed, 6 insertions, 1 deletions
@@ -4688,7 +4688,7 @@ Init_Regexp(void) rb_cRegexp = rb_define_class("Regexp", rb_cObject); rb_define_alloc_func(rb_cRegexp, rb_reg_s_alloc); - rb_define_singleton_method(rb_cRegexp, "compile", rb_class_new_instance, -1); + rb_define_singleton_method(rb_cRegexp, "compile", rb_class_new_instance_pass_kw, -1); rb_define_singleton_method(rb_cRegexp, "quote", rb_reg_s_quote, 1); rb_define_singleton_method(rb_cRegexp, "escape", rb_reg_s_quote, 1); rb_define_singleton_method(rb_cRegexp, "union", rb_reg_s_union_m, -2); diff --git a/test/ruby/test_regexp.rb b/test/ruby/test_regexp.rb index 4a2ee9dc4c..37375c0e3a 100644 --- a/test/ruby/test_regexp.rb +++ b/test/ruby/test_regexp.rb @@ -700,6 +700,11 @@ class TestRegexp < Test::Unit::TestCase assert_equal(//n, Regexp.new("", Regexp::NOENCODING, timeout: 1)) assert_equal(arg_encoding_none, Regexp.new("", Regexp::NOENCODING).options) + + assert_nil(Regexp.new("").timeout) + assert_equal(1.0, Regexp.new("", timeout: 1.0).timeout) + assert_nil(Regexp.compile("").timeout) + assert_equal(1.0, Regexp.compile("", timeout: 1.0).timeout) end assert_raise(RegexpError) { Regexp.new(")(") } |
