summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-07-30 14:06:52 +0000
committerusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-07-30 14:06:52 +0000
commit5b5739df1cda2fef43e69de11455c17a8b1aef09 (patch)
tree1331e10abf8b279ab89b3ce9e90929edad227638
parent08c74b7593c1b338b92bdfcfdb43543d24bb1746 (diff)
merge revision(s) 63698: [Backport #14856]
lib/drb/extservm.rb (service): do not return `false' invoke_service_command may set entries in @servers to `false', making it incompatible with the intended use of the safe navigation operator. This caused occasional DRb test failures, but they were hidden with automatic retry. [ruby-core:87524] [Bug #14856] Fixes: r53111 ("use safe navigation operator") commit 059c9c1cf371e049c7481c78b76e9620da52757f [GH-1142] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64128 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--lib/drb/extservm.rb2
-rw-r--r--version.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/drb/extservm.rb b/lib/drb/extservm.rb
index 7e70a3cd82..5649da5c72 100644
--- a/lib/drb/extservm.rb
+++ b/lib/drb/extservm.rb
@@ -38,7 +38,7 @@ module DRb
synchronize do
while true
server = @servers[name]
- return server if server&.alive?
+ return server if server && server.alive? # server may be `false'
invoke_service(name)
@cond.wait
end
diff --git a/version.h b/version.h
index 2bd9ff02f0..ce5d9a2947 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.4.5"
#define RUBY_RELEASE_DATE "2018-07-30"
-#define RUBY_PATCHLEVEL 308
+#define RUBY_PATCHLEVEL 309
#define RUBY_RELEASE_YEAR 2018
#define RUBY_RELEASE_MONTH 7