summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-25 18:13:17 +0000
committerusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-25 18:13:17 +0000
commitd41018464386c1ce686a65af03fb711a9af1baa1 (patch)
tree1aabc37864c9f6216539240165e29154f7c6573f
parentd014f463cf6d5dd51aa2ce56385fc08ac5c121af (diff)
merge revision(s) 57024: [Backport #13015]
vm.c: check type of hash to merge * vm.c (core_hash_merge): check the type of the target hash to merge. [ruby-core:78536] [Bug #13015] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@58116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--test/ruby/test_keyword.rb20
-rw-r--r--version.h2
-rw-r--r--vm.c4
3 files changed, 24 insertions, 2 deletions
diff --git a/test/ruby/test_keyword.rb b/test/ruby/test_keyword.rb
index df366845fe..3454c72d05 100644
--- a/test/ruby/test_keyword.rb
+++ b/test/ruby/test_keyword.rb
@@ -615,4 +615,24 @@ class TestKeywordArguments < Test::Unit::TestCase
assert_equal(x, result)
assert_kind_of(klass, result, bug12884)
end
+
+ def test_kwrest_overwritten
+ bug13015 = '[ruby-core:78536] [Bug #13015]'
+
+ klass = EnvUtil.labeled_class("Parent") do
+ def initialize(d:)
+ end
+ end
+
+ klass = EnvUtil.labeled_class("Child", klass) do
+ def initialize(d:, **h)
+ h = [2, 3]
+ super
+ end
+ end
+
+ assert_raise_with_message(TypeError, /expected Hash/, bug13015) do
+ klass.new(d: 4)
+ end
+ end
end
diff --git a/version.h b/version.h
index 86dd75ae77..92210031ee 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.2.7"
#define RUBY_RELEASE_DATE "2017-03-26"
-#define RUBY_PATCHLEVEL 448
+#define RUBY_PATCHLEVEL 449
#define RUBY_RELEASE_YEAR 2017
#define RUBY_RELEASE_MONTH 3
diff --git a/vm.c b/vm.c
index 78de622d31..615c4c9cc9 100644
--- a/vm.c
+++ b/vm.c
@@ -2345,6 +2345,7 @@ core_hash_merge(VALUE hash, long argc, const VALUE *argv)
{
long i;
+ Check_Type(hash, T_HASH);
assert(argc % 2 == 0);
for (i=0; i<argc; i+=2) {
rb_hash_aset(hash, argv[i], argv[i+1]);
@@ -2366,7 +2367,7 @@ core_hash_from_ary(VALUE ary)
VALUE hash = rb_hash_new();
if (RUBY_DTRACE_HASH_CREATE_ENABLED()) {
- RUBY_DTRACE_HASH_CREATE(RARRAY_LEN(ary), rb_sourcefile(), rb_sourceline());
+ RUBY_DTRACE_HASH_CREATE((Check_Type(ary, T_ARRAY), RARRAY_LEN(ary)), rb_sourcefile(), rb_sourceline());
}
return core_hash_merge_ary(hash, ary);
@@ -2382,6 +2383,7 @@ m_core_hash_merge_ary(VALUE self, VALUE hash, VALUE ary)
static VALUE
core_hash_merge_ary(VALUE hash, VALUE ary)
{
+ Check_Type(ary, T_ARRAY);
core_hash_merge(hash, RARRAY_LEN(ary), RARRAY_CONST_PTR(ary));
return hash;
}