summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-03-28 13:41:03 +0000
committeryugui <yugui@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-03-28 13:41:03 +0000
commit73dae42f511b359a1c649b253a3558cc129db91e (patch)
tree953b079ce51ba850c0f9127a47aac3d0c2cb0859
parentbb40ff921676511a54c171a83dc3f3afe8b617f3 (diff)
merges r30772,r30773 and r30776 from trunk into ruby_1_9_2.
-- * ext/zlib/zlib.c (gzfile_reader_get_unused): use rb_str_new_shared because gz->z.input is hidden string. [ruby-core:35057] -- e ext/zlib/zlib.c (gzfile_reader_get_unused): use rb_str_resurrect -- * ext/zlib/zlib.c (gzfile_reader_get_unused): no need to dup before rb_str_resurrect. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@31204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog10
-rw-r--r--ext/zlib/zlib.c2
-rw-r--r--test/zlib/test_zlib.rb44
-rw-r--r--version.h2
4 files changed, 48 insertions, 10 deletions
diff --git a/ChangeLog b/ChangeLog
index 3e8195d1d0..54b21ed857 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+Fri Feb 4 00:14:55 2011 Nobuyoshi Nakada <nobu@ruby-lang.org>
+
+ * ext/zlib/zlib.c (gzfile_reader_get_unused): no need to dup
+ before rb_str_resurrect.
+
+Thu Feb 3 18:33:26 2011 NARUSE, Yui <naruse@ruby-lang.org>
+
+ e ext/zlib/zlib.c (gzfile_reader_get_unused): use rb_str_resurrect
+ because gz->z.input is hidden string. [ruby-core:35057]
+
Thu Feb 3 07:02:16 2011 Aaron Patterson <aaron@tenderlovemaking.com>
* ext/psych/lib/psych/visitors/to_ruby.rb: ARG_ENCODING_NONE regular
diff --git a/ext/zlib/zlib.c b/ext/zlib/zlib.c
index c52ebf3020..c454d26e04 100644
--- a/ext/zlib/zlib.c
+++ b/ext/zlib/zlib.c
@@ -2400,7 +2400,7 @@ gzfile_reader_get_unused(struct gzfile *gz)
}
if (NIL_P(gz->z.input)) return Qnil;
- str = rb_str_dup(gz->z.input);
+ str = rb_str_resurrect(gz->z.input);
OBJ_TAINT(str); /* for safe */
return str;
}
diff --git a/test/zlib/test_zlib.rb b/test/zlib/test_zlib.rb
index 6b13cf6026..5432ce2c1a 100644
--- a/test/zlib/test_zlib.rb
+++ b/test/zlib/test_zlib.rb
@@ -86,7 +86,7 @@ if defined? Zlib
def test_adler
z = Zlib::Deflate.new
z << "foo"
- s = z.finish
+ z.finish
assert_equal(0x02820145, z.adler)
end
@@ -95,7 +95,7 @@ if defined? Zlib
assert_equal(false, z.finished?)
z << "foo"
assert_equal(false, z.finished?)
- s = z.finish
+ z.finish
assert_equal(true, z.finished?)
z.close
assert_raise(Zlib::Error) { z.finished? }
@@ -459,12 +459,40 @@ if defined? Zlib
t.close
Zlib::GzipWriter.open(t.path) {|gz| gz.print("foobar") }
- f = Zlib::GzipReader.open(t.path)
- assert_equal("foo", f.read(3))
- f.unused
- assert_equal("bar", f.read)
- f.unused
- f.close
+ Zlib::GzipReader.open(t.path) do |f|
+ assert_equal(nil, f.unused)
+ assert_equal("foo", f.read(3))
+ assert_equal(nil, f.unused)
+ assert_equal("bar", f.read)
+ assert_equal(nil, f.unused)
+ end
+ end
+
+ def test_unused2
+ zio = StringIO.new
+
+ io = Zlib::GzipWriter.new zio
+ io.write 'aaaa'
+ io.finish
+
+ io = Zlib::GzipWriter.new zio
+ io.write 'bbbb'
+ io.finish
+
+ zio.rewind
+
+ io = Zlib::GzipReader.new zio
+ assert_equal('aaaa', io.read)
+ unused = io.unused
+ assert_equal(24, unused.bytesize)
+ io.finish
+
+ zio.pos -= unused.length
+
+ io = Zlib::GzipReader.new zio
+ assert_equal('bbbb', io.read)
+ assert_equal(nil, io.unused)
+ io.finish
end
def test_read
diff --git a/version.h b/version.h
index f573c95940..9a4fb851e4 100644
--- a/version.h
+++ b/version.h
@@ -1,5 +1,5 @@
#define RUBY_VERSION "1.9.2"
-#define RUBY_PATCHLEVEL 187
+#define RUBY_PATCHLEVEL 188
#define RUBY_VERSION_MAJOR 1
#define RUBY_VERSION_MINOR 9
#define RUBY_VERSION_TEENY 1