# frozen_string_literal: true RSpec.describe "bundle update" do describe "with no arguments" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "updates the entire bundle" do update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "activesupport", "3.0" end bundle "update" expect(out).to include("Bundle updated!") expect(the_bundle).to include_gems "rack 1.2", "rack-obama 1.0", "activesupport 3.0" end it "doesn't delete the Gemfile.lock file if something goes wrong" do gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" exit! G bundle "update", :raise_on_error => false expect(bundled_app_lock).to exist end end describe "with --all" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "updates the entire bundle" do update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "activesupport", "3.0" end bundle "update", :all => true expect(out).to include("Bundle updated!") expect(the_bundle).to include_gems "rack 1.2", "rack-obama 1.0", "activesupport 3.0" end it "doesn't delete the Gemfile.lock file if something goes wrong" do install_gemfile "source \"#{file_uri_for(gem_repo1)}\"" gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" exit! G bundle "update", :all => true, :raise_on_error => false expect(bundled_app_lock).to exist end end describe "with --gemfile" do it "creates lock files based on the Gemfile name" do gemfile bundled_app("OmgFile"), <<-G source "#{file_uri_for(gem_repo1)}" gem "rack", "1.0" G bundle "update --gemfile OmgFile", :all => true expect(bundled_app("OmgFile.lock")).to exist end end context "when update_requires_all_flag is set" do before { bundle "config set update_requires_all_flag true" } it "errors when passed nothing" do install_gemfile "source \"#{file_uri_for(gem_repo1)}\"" bundle :update, :raise_on_error => false expect(err).to eq("To update everything, pass the `--all` flag.") end it "errors when passed --all and another option" do install_gemfile "source \"#{file_uri_for(gem_repo1)}\"" bundle "update --all foo", :raise_on_error => false expect(err).to eq("Cannot specify --all along with specific options.") end it "updates everything when passed --all" do install_gemfile "source \"#{file_uri_for(gem_repo1)}\"" bundle "update --all" expect(out).to include("Bundle updated!") end end describe "--quiet argument" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "hides UI messages" do bundle "update --quiet" expect(out).not_to include("Bundle updated!") end end describe "with a top level dependency" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "unlocks all child dependencies that are unrelated to other locked dependencies" do update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "activesupport", "3.0" end bundle "update rack-obama" expect(the_bundle).to include_gems "rack 1.2", "rack-obama 1.0", "activesupport 2.3.5" end end describe "with an unknown dependency" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "should inform the user" do bundle "update halting-problem-solver", :raise_on_error => false expect(err).to include "Could not find gem 'halting-problem-solver'" end it "should suggest alternatives" do bundle "update platformspecific", :raise_on_error => false expect(err).to include "Did you mean platform_specific?" end end describe "with a child dependency" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "should update the child dependency" do update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end end bundle "update rack" expect(the_bundle).to include_gems "rack 1.2" end end describe "when a possible resolve requires an older version of a locked gem" do it "does not go to an older version" do build_repo4 do build_gem "tilt", "2.0.8" build_gem "slim", "3.0.9" do |s| s.add_dependency "tilt", [">= 1.3.3", "< 2.1"] end build_gem "slim_lint", "0.16.1" do |s| s.add_dependency "slim", [">= 3.0", "< 5.0"] end build_gem "slim-rails", "0.2.1" do |s| s.add_dependency "slim", ">= 0.9.2" end build_gem "slim-rails", "3.1.3" do |s| s.add_dependency "slim", "~> 3.0" end end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "slim-rails" gem "slim_lint" G expect(the_bundle).to include_gems("slim 3.0.9", "slim-rails 3.1.3", "slim_lint 0.16.1") update_repo4 do build_gem "slim", "4.0.0" do |s| s.add_dependency "tilt", [">= 2.0.6", "< 2.1"] end end bundle "update", :all => true expect(the_bundle).to include_gems("slim 3.0.9", "slim-rails 3.1.3", "slim_lint 0.16.1") end it "does not go to an older version, even if the version upgrade that could cause another gem to downgrade is activated first" do build_repo4 do # countries is processed before country_select by the resolver due to having less spec groups (groups of versions with the same dependencies) (2 vs 3) build_gem "countries", "2.1.4" build_gem "countries", "3.1.0" build_gem "countries", "4.0.0" do |s| s.add_dependency "sixarm_ruby_unaccent", "~> 1.1" end build_gem "country_select", "1.2.0" build_gem "country_select", "2.1.4" do |s| s.add_dependency "countries", "~> 2.0" end build_gem "country_select", "3.1.1" do |s| s.add_dependency "countries", "~> 2.0" end build_gem "country_select", "5.1.0" do |s| s.add_dependency "countries", "~> 3.0" end build_gem "sixarm_ruby_unaccent", "1.1.0" end gemfile <<~G source "#{file_uri_for(gem_repo4)}" gem "country_select" gem "countries" G lockfile <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: countries (3.1.0) country_select (5.1.0) countries (~> 3.0) PLATFORMS #{specific_local_platform} DEPENDENCIES countries country_select BUNDLED WITH #{Bundler::VERSION} L previous_lockfile = lockfile bundle "lock --update" expect(lockfile).to eq(previous_lockfile) end it "does not downgrade indirect dependencies unnecessarily" do build_repo4 do build_gem "a" do |s| s.add_dependency "b" s.add_dependency "c" end build_gem "b" build_gem "c" build_gem "c", "2.0" end install_gemfile <<-G, :verbose => true source "#{file_uri_for(gem_repo4)}" gem "a" G expect(the_bundle).to include_gems("a 1.0", "b 1.0", "c 2.0") update_repo4 do build_gem "b", "2.0" do |s| s.add_dependency "c", "< 2" end end bundle "update", :all => true, :verbose => true expect(the_bundle).to include_gems("a 1.0", "b 1.0", "c 2.0") end it "should still downgrade if forced by the Gemfile" do build_repo4 do build_gem "a" build_gem "b", "1.0" build_gem "b", "2.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "a" gem "b" G expect(the_bundle).to include_gems("a 1.0", "b 2.0") gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "a" gem "b", "1.0" G bundle "update b" expect(the_bundle).to include_gems("a 1.0", "b 1.0") end it "should still downgrade if forced by the Gemfile, when transitive dependencies also need downgrade" do build_repo4 do build_gem "activesupport", "6.1.4.1" do |s| s.add_dependency "tzinfo", "~> 2.0" end build_gem "activesupport", "6.0.4.1" do |s| s.add_dependency "tzinfo", "~> 1.1" end build_gem "tzinfo", "2.0.4" build_gem "tzinfo", "1.2.9" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "activesupport", "~> 6.1.0" G expect(the_bundle).to include_gems("activesupport 6.1.4.1", "tzinfo 2.0.4") gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "activesupport", "~> 6.0.0" G original_lockfile = lockfile expected_lockfile = <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: activesupport (6.0.4.1) tzinfo (~> 1.1) tzinfo (1.2.9) PLATFORMS #{lockfile_platforms} DEPENDENCIES activesupport (~> 6.0.0) BUNDLED WITH #{Bundler::VERSION} L bundle "update activesupport" expect(the_bundle).to include_gems("activesupport 6.0.4.1", "tzinfo 1.2.9") expect(lockfile).to eq(expected_lockfile) lockfile original_lockfile bundle "update" expect(the_bundle).to include_gems("activesupport 6.0.4.1", "tzinfo 1.2.9") expect(lockfile).to eq(expected_lockfile) lockfile original_lockfile bundle "lock --update" expect(the_bundle).to include_gems("activesupport 6.0.4.1", "tzinfo 1.2.9") expect(lockfile).to eq(expected_lockfile) end end describe "with --local option" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "doesn't hit repo2" do FileUtils.rm_rf(gem_repo2) bundle "update --local --all" expect(out).not_to include("Fetching source index") end end describe "with --group option" do before do build_repo2 end it "should update only specified group gems" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport", :group => :development gem "rack" G update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "activesupport", "3.0" end bundle "update --group development" expect(the_bundle).to include_gems "activesupport 3.0" expect(the_bundle).not_to include_gems "rack 1.2" end context "when conservatively updating a group with non-group sub-deps" do it "should update only specified group gems" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activemerchant", :group => :development gem "activesupport" G update_repo2 do build_gem "activemerchant", "2.0" build_gem "activesupport", "3.0" end bundle "update --conservative --group development" expect(the_bundle).to include_gems "activemerchant 2.0" expect(the_bundle).not_to include_gems "activesupport 3.0" end end context "when there is a source with the same name as a gem in a group" do before do build_git "foo", :path => lib_path("activesupport") install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport", :group => :development gem "foo", :git => "#{lib_path("activesupport")}" G end it "should not update the gems from that source" do update_repo2 { build_gem "activesupport", "3.0" } update_git "foo", "2.0", :path => lib_path("activesupport") bundle "update --group development" expect(the_bundle).to include_gems "activesupport 3.0" expect(the_bundle).not_to include_gems "foo 2.0" end end context "when bundler itself is a transitive dependency" do it "executes without error" do install_gemfile <<-G source "#{file_uri_for(gem_repo1)}" gem "activesupport", :group => :development gem "rack" G update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "activesupport", "3.0" end bundle "update --group development" expect(the_bundle).to include_gems "activesupport 2.3.5" expect(the_bundle).to include_gems "bundler #{Bundler::VERSION}" expect(the_bundle).not_to include_gems "rack 1.2" end end end describe "in a frozen bundle" do before do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" gem "rack-obama" gem "platform_specific" G end it "should fail loudly", :bundler => "< 3" do bundle "install --deployment" bundle "update", :all => true, :raise_on_error => false expect(last_command).to be_failure expect(err).to match(/You are trying to install in deployment mode after changing.your Gemfile/m) expect(err).to match(/freeze \nby running `bundle config unset deployment`./m) end it "should suggest different command when frozen is set globally", :bundler => "< 3" do bundle "config set --global frozen 1" bundle "update", :all => true, :raise_on_error => false expect(err).to match(/You are trying to install in deployment mode after changing.your Gemfile/m). and match(/freeze \nby running `bundle config unset frozen`./m) end it "should suggest different command when frozen is set globally", :bundler => "3" do bundle "config set --global deployment true" bundle "update", :all => true, :raise_on_error => false expect(err).to match(/You are trying to install in deployment mode after changing.your Gemfile/m). and match(/freeze \nby running `bundle config unset deployment`./m) end end describe "with --source option" do before do build_repo2 end it "should not update gems not included in the source that happen to have the same name" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" G update_repo2 { build_gem "activesupport", "3.0" } bundle "update --source activesupport" expect(the_bundle).not_to include_gem "activesupport 3.0" end it "should not update gems not included in the source that happen to have the same name" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" G update_repo2 { build_gem "activesupport", "3.0" } bundle "update --source activesupport" expect(the_bundle).not_to include_gems "activesupport 3.0" end end context "when there is a child dependency that is also in the gemfile" do before do build_repo2 do build_gem "fred", "1.0" build_gem "harry", "1.0" do |s| s.add_dependency "fred" end end install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "harry" gem "fred" G end it "should not update the child dependencies of a gem that has the same name as the source" do update_repo2 do build_gem "fred", "2.0" build_gem "harry", "2.0" do |s| s.add_dependency "fred" end end bundle "update --source harry" expect(the_bundle).to include_gems "harry 1.0", "fred 1.0" end end context "when there is a child dependency that appears elsewhere in the dependency graph" do before do build_repo2 do build_gem "fred", "1.0" do |s| s.add_dependency "george" end build_gem "george", "1.0" build_gem "harry", "1.0" do |s| s.add_dependency "george" end end install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "harry" gem "fred" G end it "should not update the child dependencies of a gem that has the same name as the source" do update_repo2 do build_gem "george", "2.0" build_gem "harry", "2.0" do |s| s.add_dependency "george" end end bundle "update --source harry" expect(the_bundle).to include_gems "harry 1.0", "fred 1.0", "george 1.0" end end it "shows the previous version of the gem when updated from rubygems source", :bundler => "< 3" do build_repo2 install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" G bundle "update", :all => true expect(out).to include("Using activesupport 2.3.5") update_repo2 do build_gem "activesupport", "3.0" end bundle "update", :all => true expect(out).to include("Installing activesupport 3.0 (was 2.3.5)") end context "with suppress_install_using_messages set" do before { bundle "config set suppress_install_using_messages true" } it "only prints `Using` for versions that have changed" do build_repo4 do build_gem "bar" build_gem "foo" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "bar" gem "foo" G bundle "update", :all => true expect(out).to match(/Resolving dependencies\.\.\.\.*\nBundle updated!/) update_repo4 do build_gem "foo", "2.0" end bundle "update", :all => true out.sub!("Removing foo (1.0)\n", "") expect(out).to match(/Resolving dependencies\.\.\.\.*\nFetching foo 2\.0 \(was 1\.0\)\nInstalling foo 2\.0 \(was 1\.0\)\nBundle updated/) end end it "shows error message when Gemfile.lock is not preset and gem is specified" do gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activesupport" G bundle "update nonexisting", :raise_on_error => false expect(err).to include("This Bundle hasn't been installed yet. Run `bundle install` to update and install the bundled gems.") expect(exitstatus).to eq(22) end context "with multiple, duplicated sources, with lockfile in old format", :bundler => "< 3" do before do build_repo2 do build_gem "dotenv", "2.7.6" build_gem "oj", "3.11.3" build_gem "oj", "3.11.5" build_gem "vcr", "6.0.0" end build_repo gem_repo3 do build_gem "pkg-gem-flowbyte-with-dep", "1.0.0" do |s| s.add_dependency "oj" end end gemfile <<~G source "https://gem.repo2" gem "dotenv" source "https://gem.repo3" do gem 'pkg-gem-flowbyte-with-dep' end gem "vcr",source: "https://gem.repo2" G lockfile <<~L GEM remote: https://gem.repo2/ remote: https://gem.repo3/ specs: dotenv (2.7.6) oj (3.11.3) pkg-gem-flowbyte-with-dep (1.0.0) oj vcr (6.0.0) PLATFORMS #{specific_local_platform} DEPENDENCIES dotenv pkg-gem-flowbyte-with-dep! vcr! BUNDLED WITH #{Bundler::VERSION} L end it "works" do bundle :install, :artifice => "compact_index" bundle "update oj", :artifice => "compact_index" expect(out).to include("Bundle updated!") expect(the_bundle).to include_gems "oj 3.11.5" end end end RSpec.describe "bundle update in more complicated situations" do before do build_repo2 end it "will eagerly unlock dependencies of a specified gem" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "thin" gem "rack-obama" G update_repo2 do build_gem "rack", "1.2" do |s| s.executables = "rackup" end build_gem "thin", "2.0" do |s| s.add_dependency "rack" end end bundle "update thin" expect(the_bundle).to include_gems "thin 2.0", "rack 1.2", "rack-obama 1.0" end it "will warn when some explicitly updated gems are not updated" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "thin" gem "rack-obama" G update_repo2 do build_gem("thin", "2.0") {|s| s.add_dependency "rack" } build_gem "rack", "10.0" end bundle "update thin rack-obama" expect(last_command.stdboth).to include "Bundler attempted to update rack-obama but its version stayed the same" expect(the_bundle).to include_gems "thin 2.0", "rack 10.0", "rack-obama 1.0" end it "will not warn when an explicitly updated git gem changes sha but not version" do build_git "foo" install_gemfile <<-G source "#{file_uri_for(gem_repo1)}" gem "foo", :git => '#{lib_path("foo-1.0")}' G update_git "foo" do |s| s.write "lib/foo2.rb", "puts :foo2" end bundle "update foo" expect(last_command.stdboth).not_to include "attempted to update" end it "will not warn when changing gem sources but not versions" do build_git "rack" install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "rack", :git => '#{lib_path("rack-1.0")}' G gemfile <<-G source "#{file_uri_for(gem_repo1)}" gem "rack" G bundle "update rack" expect(last_command.stdboth).not_to include "attempted to update" end it "will update only from pinned source" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" source "#{file_uri_for(gem_repo1)}" do gem "thin" end G update_repo2 do build_gem "thin", "2.0" end bundle "update" expect(the_bundle).to include_gems "thin 1.0" end context "when the lockfile is for a different platform" do before do build_repo4 do build_gem("a", "0.9") build_gem("a", "0.9") {|s| s.platform = "java" } build_gem("a", "1.1") build_gem("a", "1.1") {|s| s.platform = "java" } end gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "a" G lockfile <<-L GEM remote: #{file_uri_for(gem_repo4)} specs: a (0.9-java) PLATFORMS java DEPENDENCIES a L simulate_platform linux end it "allows updating" do bundle :update, :all => true expect(the_bundle).to include_gem "a 1.1" end it "allows updating a specific gem" do bundle "update a" expect(the_bundle).to include_gem "a 1.1" end end context "when the dependency is for a different platform" do before do build_repo4 do build_gem("a", "0.9") {|s| s.platform = "java" } build_gem("a", "1.1") {|s| s.platform = "java" } end gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "a", platform: :jruby G lockfile <<-L GEM remote: #{file_uri_for(gem_repo4)} specs: a (0.9-java) PLATFORMS java DEPENDENCIES a L simulate_platform linux end it "is not updated because it is not actually included in the bundle" do bundle "update a" expect(last_command.stdboth).to include "Bundler attempted to update a but it was not considered because it is for a different platform from the current one" expect(the_bundle).to_not include_gem "a" end end end RSpec.describe "bundle update without a Gemfile.lock" do it "should not explode" do build_repo2 gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "rack", "1.0" G bundle "update", :all => true expect(the_bundle).to include_gems "rack 1.0.0" end end RSpec.describe "bundle update when a gem depends on a newer version of bundler" do before do build_repo2 do build_gem "rails", "3.0.1" do |s| s.add_dependency "bundler", Bundler::VERSION.succ end build_gem "bundler", Bundler::VERSION.succ end gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "rails", "3.0.1" G end it "should explain that bundler conflicted and how to resolve the conflict" do bundle "update", :all => true, :raise_on_error => false expect(last_command.stdboth).not_to match(/in snapshot/i) expect(err).to match(/current Bundler version/i). and match(/Install the necessary version with `gem install bundler:#{Bundler::VERSION.succ}`/i) end end RSpec.describe "bundle update --ruby" do context "when the Gemfile removes the ruby" do before do install_gemfile <<-G ruby '~> #{RUBY_VERSION}' source "#{file_uri_for(gem_repo1)}" G gemfile <<-G source "#{file_uri_for(gem_repo1)}" G end it "removes the Ruby from the Gemfile.lock" do bundle "update --ruby" expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo1)}/ specs: PLATFORMS #{lockfile_platforms} DEPENDENCIES BUNDLED WITH #{Bundler::VERSION} L end end context "when the Gemfile specified an updated Ruby version" do before do install_gemfile <<-G ruby '~> #{RUBY_VERSION}' source "#{file_uri_for(gem_repo1)}" G gemfile <<-G ruby '~> #{RUBY_VERSION[0..2]}' source "#{file_uri_for(gem_repo1)}" G end it "updates the Gemfile.lock with the latest version" do bundle "update --ruby" expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo1)}/ specs: PLATFORMS #{lockfile_platforms} DEPENDENCIES RUBY VERSION #{Bundler::RubyVersion.system} BUNDLED WITH #{Bundler::VERSION} L end end context "when a different Ruby is being used than has been versioned" do before do install_gemfile <<-G ruby '~> #{RUBY_VERSION}' source "#{file_uri_for(gem_repo1)}" G gemfile <<-G ruby '~> 2.1.0' source "#{file_uri_for(gem_repo1)}" G end it "shows a helpful error message" do bundle "update --ruby", :raise_on_error => false expect(err).to include("Your Ruby version is #{Bundler::RubyVersion.system.gem_version}, but your Gemfile specified ~> 2.1.0") end end context "when updating Ruby version and Gemfile `ruby`" do before do lockfile <<~L GEM remote: #{file_uri_for(gem_repo1)}/ specs: PLATFORMS #{lockfile_platforms} DEPENDENCIES RUBY VERSION ruby 2.1.4p222 BUNDLED WITH #{Bundler::VERSION} L gemfile <<-G ruby '~> #{RUBY_VERSION}' source "#{file_uri_for(gem_repo1)}" G end it "updates the Gemfile.lock with the latest version" do bundle "update --ruby" expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo1)}/ specs: PLATFORMS #{lockfile_platforms} DEPENDENCIES RUBY VERSION #{Bundler::RubyVersion.system} BUNDLED WITH #{Bundler::VERSION} L end end end RSpec.describe "bundle update --bundler" do it "updates the bundler version in the lockfile without re-resolving" do build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G lockfile lockfile.sub(/(^\s*)#{Bundler::VERSION}($)/, '\11.0.0\2') FileUtils.rm_r gem_repo4 bundle :update, :bundler => true, :artifice => "compact_index", :verbose => true expect(out).to include("Using bundler #{Bundler::VERSION}") expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: rack (1.0) PLATFORMS #{lockfile_platforms} DEPENDENCIES rack BUNDLED WITH #{Bundler::VERSION} L expect(the_bundle).to include_gem "rack 1.0" end it "updates the bundler version in the lockfile without re-resolving if the highest version is already installed" do system_gems "bundler-2.3.9" build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G lockfile lockfile.sub(/(^\s*)#{Bundler::VERSION}($)/, "2.3.9") bundle :update, :bundler => true, :artifice => "compact_index", :verbose => true expect(out).to include("Using bundler #{Bundler::VERSION}") expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: rack (1.0) PLATFORMS #{lockfile_platforms} DEPENDENCIES rack BUNDLED WITH #{Bundler::VERSION} L expect(the_bundle).to include_gem "rack 1.0" end it "updates the bundler version in the lockfile even if the latest version is not installed", :ruby_repo, :realworld do skip "ruby-head has a default Bundler version too high for this spec to work" if RUBY_PATCHLEVEL == -1 pristine_system_gems "bundler-2.3.9" build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G lockfile lockfile.sub(/(^\s*)#{Bundler::VERSION}($)/, "2.3.9") bundle :update, :bundler => true, :artifice => "vcr", :verbose => true # Only updates properly on modern RubyGems. if Gem.rubygems_version >= Gem::Version.new("3.3.0.dev") expect(out).to include("Updating bundler to 2.3.10") expect(out).to include("Using bundler 2.3.10") expect(out).not_to include("Installing Bundler 2.3.9 and restarting using that version.") expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: rack (1.0) PLATFORMS #{lockfile_platforms} DEPENDENCIES rack BUNDLED WITH 2.3.10 L expect(the_bundle).to include_gems "bundler 2.3.10" end expect(the_bundle).to include_gems "rack 1.0" end it "errors if the explicit target version does not exist", :realworld do skip "ruby-head has a default Bundler version too high for this spec to work" if RUBY_PATCHLEVEL == -1 pristine_system_gems "bundler-2.3.9" build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G lockfile lockfile.sub(/(^\s*)#{Bundler::VERSION}($)/, "2.3.9") bundle :update, :bundler => "999.999.999", :artifice => "vcr", :raise_on_error => false # Only gives a meaningful error message on modern RubyGems. if Gem.rubygems_version >= Gem::Version.new("3.3.0.dev") expect(last_command).to be_failure expect(err).to include("The `bundle update --bundler` target version (999.999.999) does not exist") end end it "allows updating to development versions if already installed locally" do system_gems "bundler-2.3.0.dev" build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G bundle :update, :bundler => "2.3.0.dev" # Only updates properly on modern RubyGems. if Gem.rubygems_version >= Gem::Version.new("3.3.0.dev") expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: rack (1.0) PLATFORMS #{lockfile_platforms} DEPENDENCIES rack BUNDLED WITH 2.3.0.dev L expect(out).to include("Using bundler 2.3.0.dev") end end it "does not touch the network if not necessary" do system_gems "bundler-2.3.9" build_repo4 do build_gem "rack", "1.0" end install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem "rack" G bundle :update, :bundler => "2.3.9", :raise_on_error => false expect(out).not_to include("Fetching gem metadata from https://rubygems.org/") # Only updates properly on modern RubyGems. if Gem.rubygems_version >= Gem::Version.new("3.3.0.dev") expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: rack (1.0) PLATFORMS #{lockfile_platforms} DEPENDENCIES rack BUNDLED WITH 2.3.9 L expect(out).to include("Using bundler 2.3.9") end end end # these specs are slow and focus on integration and therefore are not exhaustive. unit specs elsewhere handle that. RSpec.describe "bundle update conservative" do context "patch and minor options" do before do build_repo4 do build_gem "foo", %w[1.4.3 1.4.4] do |s| s.add_dependency "bar", "~> 2.0" end build_gem "foo", %w[1.4.5 1.5.0] do |s| s.add_dependency "bar", "~> 2.1" end build_gem "foo", %w[1.5.1] do |s| s.add_dependency "bar", "~> 3.0" end build_gem "bar", %w[2.0.3 2.0.4 2.0.5 2.1.0 2.1.1 3.0.0] build_gem "qux", %w[1.0.0 1.0.1 1.1.0 2.0.0] end # establish a lockfile set to 1.4.3 install_gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem 'foo', '1.4.3' gem 'bar', '2.0.3' gem 'qux', '1.0.0' G # remove 1.4.3 requirement and bar altogether # to setup update specs below gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem 'foo' gem 'qux' G end context "with patch set as default update level in config" do it "should do a patch level update" do bundle "config set --local prefer_patch true" bundle "update foo" expect(the_bundle).to include_gems "foo 1.4.5", "bar 2.1.1", "qux 1.0.0" end end context "patch preferred" do it "single gem updates dependent gem to minor" do bundle "update --patch foo" expect(the_bundle).to include_gems "foo 1.4.5", "bar 2.1.1", "qux 1.0.0" end it "update all" do bundle "update --patch", :all => true expect(the_bundle).to include_gems "foo 1.4.5", "bar 2.1.1", "qux 1.0.1" end end context "minor preferred" do it "single gem updates dependent gem to major" do bundle "update --minor foo" expect(the_bundle).to include_gems "foo 1.5.1", "bar 3.0.0", "qux 1.0.0" end end context "strict" do it "patch preferred" do bundle "update --patch foo bar --strict" expect(the_bundle).to include_gems "foo 1.4.4", "bar 2.0.5", "qux 1.0.0" end it "minor preferred" do bundle "update --minor --strict", :all => true expect(the_bundle).to include_gems "foo 1.5.0", "bar 2.1.1", "qux 1.1.0" end end end context "eager unlocking" do before do build_repo4 do build_gem "isolated_owner", %w[1.0.1 1.0.2] do |s| s.add_dependency "isolated_dep", "~> 2.0" end build_gem "isolated_dep", %w[2.0.1 2.0.2] build_gem "shared_owner_a", %w[3.0.1 3.0.2] do |s| s.add_dependency "shared_dep", "~> 5.0" end build_gem "shared_owner_b", %w[4.0.1 4.0.2] do |s| s.add_dependency "shared_dep", "~> 5.0" end build_gem "shared_dep", %w[5.0.1 5.0.2] end gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem 'isolated_owner' gem 'shared_owner_a' gem 'shared_owner_b' G lockfile <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: isolated_dep (2.0.1) isolated_owner (1.0.1) isolated_dep (~> 2.0) shared_dep (5.0.1) shared_owner_a (3.0.1) shared_dep (~> 5.0) shared_owner_b (4.0.1) shared_dep (~> 5.0) PLATFORMS #{specific_local_platform} DEPENDENCIES isolated_owner shared_owner_a shared_owner_b BUNDLED WITH #{Bundler::VERSION} L end it "should eagerly unlock isolated dependency" do bundle "update isolated_owner" expect(the_bundle).to include_gems "isolated_owner 1.0.2", "isolated_dep 2.0.2", "shared_dep 5.0.1", "shared_owner_a 3.0.1", "shared_owner_b 4.0.1" end it "should eagerly unlock shared dependency" do bundle "update shared_owner_a" expect(the_bundle).to include_gems "isolated_owner 1.0.1", "isolated_dep 2.0.1", "shared_dep 5.0.2", "shared_owner_a 3.0.2", "shared_owner_b 4.0.1" end it "should not eagerly unlock with --conservative" do bundle "update --conservative shared_owner_a isolated_owner" expect(the_bundle).to include_gems "isolated_owner 1.0.2", "isolated_dep 2.0.1", "shared_dep 5.0.1", "shared_owner_a 3.0.2", "shared_owner_b 4.0.1" end it "should only update direct dependencies when fully updating with --conservative" do bundle "update --conservative" expect(the_bundle).to include_gems "isolated_owner 1.0.2", "isolated_dep 2.0.1", "shared_dep 5.0.1", "shared_owner_a 3.0.2", "shared_owner_b 4.0.2" end it "should only change direct dependencies when updating the lockfile with --conservative" do bundle "lock --update --conservative" expect(lockfile).to eq <<~L GEM remote: #{file_uri_for(gem_repo4)}/ specs: isolated_dep (2.0.1) isolated_owner (1.0.2) isolated_dep (~> 2.0) shared_dep (5.0.1) shared_owner_a (3.0.2) shared_dep (~> 5.0) shared_owner_b (4.0.2) shared_dep (~> 5.0) PLATFORMS #{specific_local_platform} DEPENDENCIES isolated_owner shared_owner_a shared_owner_b BUNDLED WITH #{Bundler::VERSION} L end it "should match bundle install conservative update behavior when not eagerly unlocking" do gemfile <<-G source "#{file_uri_for(gem_repo4)}" gem 'isolated_owner', '1.0.2' gem 'shared_owner_a', '3.0.2' gem 'shared_owner_b' G bundle "install" expect(the_bundle).to include_gems "isolated_owner 1.0.2", "isolated_dep 2.0.2", "shared_dep 5.0.1", "shared_owner_a 3.0.2", "shared_owner_b 4.0.1" end end context "error handling" do before do gemfile "source \"#{file_uri_for(gem_repo1)}\"" end it "raises if too many flags are provided" do bundle "update --patch --minor", :all => true, :raise_on_error => false expect(err).to eq "Provide only one of the following options: minor, patch" end end end