From 24fff7504595dcbc5466d209485b13074fb33a3d Mon Sep 17 00:00:00 2001 From: shyouhei Date: Thu, 8 Nov 2018 05:06:52 +0000 Subject: avoid (size_t)-- The decrements overflow and these variables remain ~0 when leaving the while loops. They are not fatal by accident, but better replace with ordinal for loops. See also: https://travis-ci.org/ruby/ruby/jobs/452218871#L3246 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- util.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'util.c') diff --git a/util.c b/util.c index 0e49e4439d..1d95da98bb 100644 --- a/util.c +++ b/util.c @@ -35,8 +35,12 @@ ruby_scan_oct(const char *start, size_t len, size_t *retlen) { register const char *s = start; register unsigned long retval = 0; + size_t i; - while (len-- && *s >= '0' && *s <= '7') { + for (i = 0; i < len; i++) { + if ((s[0] < '0') || ('7' <= s[0])) { + break; + } retval <<= 3; retval |= *s++ - '0'; } -- cgit v1.2.3