From fb75e99efea67ad3c2f802817345f749ffaf202c Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Sun, 18 Jan 2026 22:48:42 +0900 Subject: [ruby/rubygems] Add missing `.binmode` for `Gem::AtomicFileWriter` In https://github.com/ruby/rubygems/pull/9202, I commented that `temp_file.binmode` is redundant. But I was wrong. We need `temp_file.binmode` even when we specify `File::BINARY`. Sorry. https://github.com/ruby/rubygems/commit/d9f1f5c6a6 --- test/rubygems/test_gem_util_atomic_file_writer.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 test/rubygems/test_gem_util_atomic_file_writer.rb (limited to 'test') diff --git a/test/rubygems/test_gem_util_atomic_file_writer.rb b/test/rubygems/test_gem_util_atomic_file_writer.rb new file mode 100644 index 0000000000..e011a38ad4 --- /dev/null +++ b/test/rubygems/test_gem_util_atomic_file_writer.rb @@ -0,0 +1,12 @@ +# frozen_string_literal: true + +require_relative "helper" +require "rubygems/util/atomic_file_writer" + +class TestGemUtilAtomicFileWriter < Gem::TestCase + def test_external_encoding + Gem::AtomicFileWriter.open(File.join(@tempdir, "test.txt")) do |file| + assert_equal(Encoding::ASCII_8BIT, file.external_encoding) + end + end +end -- cgit v1.2.3