From aefc98891c42024039f19ef45bdfe93fbc590b7c Mon Sep 17 00:00:00 2001 From: Jun Aruga Date: Wed, 3 Jan 2024 17:34:39 +0100 Subject: readline: Skip the test_interrupt_in_other_thread on arm32. Skip the test_interrupt_in_other_thread test failing on Travis arm32. The failing test is not a new issue. It had already been skipped in .travis.yml before updating .travis.yml. https://github.com/ruby/ruby/blob/7b05cb8dbbd637910757f402e64da3908b4bb809/.travis.yml#L99-L101 Note that RUBY_PLATFORM is "armv8l-linux-eabihf" on Travis arm32 pipeline. And the readline was deleted in both master and ruby_3_3 branches. https://github.com/ruby/ruby/commit/59fd67fc3d405e529e038172e769ff20a8fb5535 So, we only need this commit on ruby_3_2 and older Ruby version branches. --- test/readline/test_readline.rb | 3 +++ 1 file changed, 3 insertions(+) (limited to 'test') diff --git a/test/readline/test_readline.rb b/test/readline/test_readline.rb index be6e65f32e..7838f4f52e 100644 --- a/test/readline/test_readline.rb +++ b/test/readline/test_readline.rb @@ -496,6 +496,9 @@ module BasetestReadline # Maybe the same issue: https://github.com/facebookresearch/nle/issues/120 omit if /i[3-6]86-linux/ =~ RUBY_PLATFORM + # Skip arm32-linux (Travis CI). + omit "Skip arm32-linux" if /armv.+l-linux/ =~ RUBY_PLATFORM + if defined?(TestReadline) && self.class == TestReadline use = "use_ext_readline" elsif defined?(TestRelineAsReadline) && self.class == TestRelineAsReadline -- cgit v1.2.3