From 7bb546a2a1f44182b15285e4e5ef9b766df07f82 Mon Sep 17 00:00:00 2001 From: akr Date: Tue, 11 Nov 2014 13:08:01 +0000 Subject: * test/net/http/test_https_proxy.rb: Use assert_join_threads. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/net/http/test_https_proxy.rb | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) (limited to 'test') diff --git a/test/net/http/test_https_proxy.rb b/test/net/http/test_https_proxy.rb index 57cabf05e0..1c8503b7e1 100644 --- a/test/net/http/test_https_proxy.rb +++ b/test/net/http/test_https_proxy.rb @@ -12,10 +12,9 @@ class HTTPSProxyTest < Test::Unit::TestCase skip 'autoload problem. see [ruby-dev:45021][Bug #5786]' end - t = nil TCPServer.open("127.0.0.1", 0) {|serv| _, port, _, _ = serv.addr - t = Thread.new { + client_thread = Thread.new { proxy = Net::HTTP.Proxy("127.0.0.1", port, 'user', 'password') http = proxy.new("foo.example.org", 8000) http.use_ssl = true @@ -25,19 +24,23 @@ class HTTPSProxyTest < Test::Unit::TestCase rescue EOFError end } - sock = serv.accept - proxy_request = sock.gets("\r\n\r\n") - assert_equal( - "CONNECT foo.example.org:8000 HTTP/1.1\r\n" + - "Host: foo.example.org:8000\r\n" + - "Proxy-Authorization: Basic dXNlcjpwYXNzd29yZA==\r\n" + - "\r\n", - proxy_request, - "[ruby-dev:25673]") - sock.close + server_thread = Thread.new { + sock = serv.accept + begin + proxy_request = sock.gets("\r\n\r\n") + assert_equal( + "CONNECT foo.example.org:8000 HTTP/1.1\r\n" + + "Host: foo.example.org:8000\r\n" + + "Proxy-Authorization: Basic dXNlcjpwYXNzd29yZA==\r\n" + + "\r\n", + proxy_request, + "[ruby-dev:25673]") + ensure + sock.close + end + } + assert_join_threads([client_thread, server_thread]) } - ensure - t.join if t end end if defined?(OpenSSL) -- cgit v1.2.3