From 08686e71d5c48325ee1bd41c8d7ebcd6c37fa496 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Thu, 8 Aug 2019 09:55:33 -0700 Subject: Do not allow Module#include to insert modules before the origin in the lookup chain Module#include should only be able to insert modules after the origin, otherwise it ends up working like Module#prepend. This fixes the case where one of the modules in the included module chain is included in a module that is already prepended to the receiver. Fixes [Bug #7844] --- test/ruby/test_module.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'test') diff --git a/test/ruby/test_module.rb b/test/ruby/test_module.rb index 6c0fe6b4a5..d63f31a56f 100644 --- a/test/ruby/test_module.rb +++ b/test/ruby/test_module.rb @@ -631,6 +631,16 @@ class TestModule < Test::Unit::TestCase assert_equal([m1, m2], m3.included_modules) end + def test_include_with_prepend + c = Class.new{def m; [:c] end} + p = Module.new{def m; [:p] + super end} + q = Module.new{def m; [:q] + super end; include p} + r = Module.new{def m; [:r] + super end; prepend q} + s = Module.new{def m; [:s] + super end; include r} + a = Class.new(c){def m; [:a] + super end; prepend p; include s} + assert_equal([:p, :a, :s, :q, :r, :c], a.new.m) + end + def test_instance_methods assert_equal([:user, :user2], User.instance_methods(false).sort) assert_equal([:user, :user2, :mixin].sort, User.instance_methods(true).sort) -- cgit v1.2.3