From c5c05460ac20abcbc0ed686eb4acf06da7a39a79 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 20 Sep 2019 19:06:22 -0700 Subject: Warn on access/modify of $SAFE, and remove effects of modifying $SAFE This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd. --- test/test_tmpdir.rb | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'test/test_tmpdir.rb') diff --git a/test/test_tmpdir.rb b/test/test_tmpdir.rb index 42bcbc00a8..c599dcf516 100644 --- a/test/test_tmpdir.rb +++ b/test/test_tmpdir.rb @@ -11,19 +11,6 @@ class TestTmpdir < Test::Unit::TestCase assert_equal(tmpdir_org, Dir.tmpdir) end - def test_tmpdir_modifiable_safe - Thread.new { - $SAFE = 1 - tmpdir = Dir.tmpdir - assert_equal(false, tmpdir.frozen?) - tmpdir_org = tmpdir.dup - tmpdir << "foo" - assert_equal(tmpdir_org, Dir.tmpdir) - }.join - ensure - $SAFE = 0 - end - def test_world_writable skip "no meaning on this platform" if /mswin|mingw/ =~ RUBY_PLATFORM Dir.mktmpdir do |tmpdir| -- cgit v1.2.3