From b957c3dbcb3cfee6908f4217cfb9ab0e78b4c618 Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Wed, 2 Jun 2021 12:32:47 +0900 Subject: [rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb", and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb". The two files are a helper for tests, not test files. However, a file starting with "test_" prefix is handled as a test file directly loaded by test-unit because Rakefile specifies: ``` t.test_files = FileList['test/**/test_*.rb'] ``` Directly loading test/rubygems/test_utilities.rb caused "uninitialized constant Gem::TestCase". This issue was fixed by 59c682097197fee4052b47e4b4ab86562f3eaa9b, but the fix caused a "circular require" warning because test_utilities.rb and test_case.rb are now requiring each other. Anyway, adding "test_" prefix to a test helper file is confusing, so this changeset reverts the fix and solve the issue by renaming them. https://github.com/rubygems/rubygems/commit/6460e018df --- test/rubygems/test_require.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/rubygems/test_require.rb') diff --git a/test/rubygems/test_require.rb b/test/rubygems/test_require.rb index 7039e27dda..1c33dafbe2 100644 --- a/test/rubygems/test_require.rb +++ b/test/rubygems/test_require.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true -require_relative 'test_case' +require_relative 'helper' require 'rubygems' class TestGemRequire < Gem::TestCase -- cgit v1.2.3