From c5c05460ac20abcbc0ed686eb4acf06da7a39a79 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 20 Sep 2019 19:06:22 -0700 Subject: Warn on access/modify of $SAFE, and remove effects of modifying $SAFE This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd. --- test/pathname/test_pathname.rb | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'test/pathname') diff --git a/test/pathname/test_pathname.rb b/test/pathname/test_pathname.rb index 39c792d18e..4d480a50f3 100644 --- a/test/pathname/test_pathname.rb +++ b/test/pathname/test_pathname.rb @@ -1467,16 +1467,6 @@ class TestPathname < Test::Unit::TestCase assert(File.fnmatch("*.*", Pathname.new("bar.baz"))) end - def test_file_join - assert_equal("foo/bar", File.join(Pathname.new("foo"), Pathname.new("bar"))) - lambda { - $SAFE = 1 - assert_equal("foo/bar", File.join(Pathname.new("foo"), Pathname.new("bar").taint)) - }.call - ensure - $SAFE = 0 - end - def test_relative_path_from_casefold assert_separately([], <<-'end;') # do module File::Constants -- cgit v1.2.3