From d249be623375e2725e1e3a979d7d47e45d356265 Mon Sep 17 00:00:00 2001 From: naruse Date: Fri, 27 Nov 2015 14:07:35 +0000 Subject: * lib/net/http.rb (connect): detect closed connection and reconnect If the server closes a keep-alive http connection, the client socket reaches EOF. To avoid an EOFError, detect the closed connection and reconnect. Added test to ensure HTTP#post succeeds even if the keep-alive-connection has been closed by the server. by Kristian Hanekamp https://github.com/ruby/ruby/pull/1089 fix GH-1089 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/net/http/test_http.rb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'test/net') diff --git a/test/net/http/test_http.rb b/test/net/http/test_http.rb index cfdf62191f..052c3ef558 100644 --- a/test/net/http/test_http.rb +++ b/test/net/http/test_http.rb @@ -896,6 +896,23 @@ class TestNetHTTPKeepAlive < Test::Unit::TestCase } end + def test_server_closed_connection_auto_reconnect + start {|http| + res = http.get('/') + http.keep_alive_timeout = 5 + assert_kind_of Net::HTTPResponse, res + assert_kind_of String, res.body + sleep 1.5 + assert_nothing_raised { + # Net::HTTP should detect the closed connection before attempting the + # request, since post requests cannot be retried. + res = http.post('/', 'query=foo', 'content-type' => 'application/x-www-form-urlencoded') + } + assert_kind_of Net::HTTPResponse, res + assert_kind_of String, res.body + } + end + def test_keep_alive_get_auto_retry start {|http| res = http.get('/') -- cgit v1.2.3