From e33dd659d43ec2302648c04fcec208b1c0f98ed9 Mon Sep 17 00:00:00 2001 From: Guillermo Guerrero Date: Fri, 12 Apr 2019 18:32:42 +0200 Subject: [bundler/bundler] Move duplicated code to `before` blocks https://github.com/bundler/bundler/commit/69bee117fb --- spec/bundler/commands/outdated_spec.rb | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) (limited to 'spec') diff --git a/spec/bundler/commands/outdated_spec.rb b/spec/bundler/commands/outdated_spec.rb index 5a60b564b8..ab54925756 100644 --- a/spec/bundler/commands/outdated_spec.rb +++ b/spec/bundler/commands/outdated_spec.rb @@ -76,7 +76,7 @@ RSpec.describe "bundle outdated" do end describe "with --group option" do - def test_group_option(group = nil, gems_list_size = 1) + before do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" @@ -87,7 +87,9 @@ RSpec.describe "bundle outdated" do gem 'activesupport', '2.3.5' end G + end + def test_group_option(group = nil, gems_list_size = 1) update_repo2 do build_gem "activesupport", "3.0" build_gem "terranova", "9" @@ -103,17 +105,6 @@ RSpec.describe "bundle outdated" do end it "not outdated gems" do - install_gemfile <<-G - source "#{file_uri_for(gem_repo2)}" - - gem "weakling", "~> 0.0.1" - gem "terranova", '8' - group :development, :test do - gem 'activesupport', '2.3.5' - gem "duradura", '7.0' - end - G - bundle "outdated --group" expect(out).to include("Bundle up to date!") end @@ -153,7 +144,7 @@ RSpec.describe "bundle outdated" do end describe "with --groups option" do - it "not outdated gems" do + before do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" @@ -164,23 +155,14 @@ RSpec.describe "bundle outdated" do gem "duradura", '7.0' end G + end + it "not outdated gems" do bundle "outdated --groups" expect(out).to include("Bundle up to date!") end it "returns a sorted list of outdated gems by groups" do - install_gemfile <<-G - source "#{file_uri_for(gem_repo2)}" - - gem "weakling", "~> 0.0.1" - gem "terranova", '8' - group :development, :test do - gem 'activesupport', '2.3.5' - gem "duradura", '7.0' - end - G - update_repo2 do build_gem "activesupport", "3.0" build_gem "terranova", "9" -- cgit v1.2.3