From 94fc709dd19ec6c6396982fef06e9b7d3ce8ae48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Sun, 7 Jun 2020 13:23:10 +0200 Subject: [rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/ The `rails_fail` name is misleading because there's no specific reason why such a gem would need to fail. As a matter of fact, `bundle install`'ing a Genfile with only that dependency like the spec the previous commit adds is not expected to fail. https://github.com/rubygems/rubygems/commit/b947f40701 --- spec/bundler/install/bundler_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'spec/bundler/install') diff --git a/spec/bundler/install/bundler_spec.rb b/spec/bundler/install/bundler_spec.rb index 5e15333ad8..9667f80435 100644 --- a/spec/bundler/install/bundler_spec.rb +++ b/spec/bundler/install/bundler_spec.rb @@ -96,7 +96,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activemerchant" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" G nice_error = <<-E.strip.gsub(/^ {8}/, "") @@ -105,7 +105,7 @@ RSpec.describe "bundle install" do activemerchant was resolved to 1.0, which depends on activesupport (>= 2.0.0) - rails_fail was resolved to 1.0, which depends on + rails_pinned_to_old_activesupport was resolved to 1.0, which depends on activesupport (= 1.2.3) E expect(err).to include(nice_error) @@ -116,7 +116,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" gem "activesupport", "2.3.5" G @@ -125,7 +125,7 @@ RSpec.describe "bundle install" do In Gemfile: activesupport (= 2.3.5) - rails_fail was resolved to 1.0, which depends on + rails_pinned_to_old_activesupport was resolved to 1.0, which depends on activesupport (= 1.2.3) E expect(err).to include(nice_error) @@ -139,7 +139,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" G expect(out).to include("Installing activesupport 1.2.3 (was 2.3.2)") -- cgit v1.2.3