From fb75e99efea67ad3c2f802817345f749ffaf202c Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Sun, 18 Jan 2026 22:48:42 +0900 Subject: [ruby/rubygems] Add missing `.binmode` for `Gem::AtomicFileWriter` In https://github.com/ruby/rubygems/pull/9202, I commented that `temp_file.binmode` is redundant. But I was wrong. We need `temp_file.binmode` even when we specify `File::BINARY`. Sorry. https://github.com/ruby/rubygems/commit/d9f1f5c6a6 --- lib/rubygems/util/atomic_file_writer.rb | 1 + 1 file changed, 1 insertion(+) (limited to 'lib') diff --git a/lib/rubygems/util/atomic_file_writer.rb b/lib/rubygems/util/atomic_file_writer.rb index ea592407eb..32767c6a79 100644 --- a/lib/rubygems/util/atomic_file_writer.rb +++ b/lib/rubygems/util/atomic_file_writer.rb @@ -30,6 +30,7 @@ module Gem flags |= File::SHARE_DELETE if defined?(File::SHARE_DELETE) File.open(tmp_path, flags) do |temp_file| + temp_file.binmode if old_stat # Set correct permissions on new file begin -- cgit v1.2.3