From da8a797335ca2248cd6aa5ab994a99ffa13a4c14 Mon Sep 17 00:00:00 2001 From: gotoyuzo Date: Sun, 30 Oct 2005 20:40:05 +0000 Subject: * lib/webrick/httpservlet/cgihandler.rb (WEBrick::HTTPServlet::CGIHandler#do_GET): the value of Set-Cookie: header field should be splited into each cookie. [ruby-Bugs:2199] * lib/webrick/cookie.rb (WEBrick::Cookie.parse_set_cookie): new method to parse the value of Set-Cookie: header field. * test/webrick/test_cookie.rb, test/webrick/test_cgi.rb, test/webrick/webrick.cgi: add some test for cookie. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@9484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- lib/webrick/cookie.rb | 24 ++++++++++++++++++++++++ lib/webrick/httpservlet/cgihandler.rb | 6 ++++++ 2 files changed, 30 insertions(+) (limited to 'lib') diff --git a/lib/webrick/cookie.rb b/lib/webrick/cookie.rb index 4785b2bb33..b9663dc791 100644 --- a/lib/webrick/cookie.rb +++ b/lib/webrick/cookie.rb @@ -76,5 +76,29 @@ module WEBrick end end + def self.parse_set_cookie(str) + cookie_elem = str.split(/;/) + first_elem = cookie_elem.shift + first_elem.strip! + key, value = first_elem.split(/=/, 2) + cookie = new(key, HTTPUtils.dequote(value)) + cookie_elem.each{|pair| + pair.strip! + key, value = pair.split(/=/, 2) + if value + value = HTTPUtils.dequote(value.strip) + end + case key.downcase + when "domain" then cookie.domain = value + when "path" then cookie.path = value + when "expires" then cookie.expires = value + when "max-age" then cookie.max_age = Integer(value) + when "comment" then cookie.comment = value + when "version" then cookie.version = Integer(value) + when "secure" then cookie.secure = true + end + } + return cookie + end end end diff --git a/lib/webrick/httpservlet/cgihandler.rb b/lib/webrick/httpservlet/cgihandler.rb index 7dd330ba7b..a35b59edb8 100644 --- a/lib/webrick/httpservlet/cgihandler.rb +++ b/lib/webrick/httpservlet/cgihandler.rb @@ -85,6 +85,12 @@ module WEBrick res.status = $1.to_i header.delete('status') end + if header.has_key?('set-cookie') + header['set-cookie'].each{|k| + res.cookies << Cookie.parse_set_cookie(k) + } + header.delete('set-cookie') + end header.each{|key, val| res[key] = val.join(", ") } rescue => ex raise HTTPStatus::InternalServerError, ex.message -- cgit v1.2.3