From afce7eb39ec58f9ec65b3cf53059a4bc3bd58cbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Tue, 24 Mar 2020 12:54:22 +0100 Subject: Replace `Gem::Util.silent_system` with better tools --- lib/rubygems/source/git.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'lib/rubygems/source') diff --git a/lib/rubygems/source/git.rb b/lib/rubygems/source/git.rb index ec2c371fa9..b76a068ed1 100644 --- a/lib/rubygems/source/git.rb +++ b/lib/rubygems/source/git.rb @@ -103,9 +103,11 @@ class Gem::Source::Git < Gem::Source success = system @git, 'reset', '--quiet', '--hard', rev_parse - success &&= - Gem::Util.silent_system @git, 'submodule', 'update', - '--quiet', '--init', '--recursive' if @need_submodules + if @need_submodules + _, status = Open3.capture2e(@git, 'submodule', 'update', '--quiet', '--init', '--recursive') + + success &&= status.success? + end success end -- cgit v1.2.3