From d154bec0d5f0dd32e0d30559ab8a0a7ed8be98d2 Mon Sep 17 00:00:00 2001 From: shyouhei Date: Tue, 15 Jan 2019 06:41:58 +0000 Subject: setbyte / ungetbyte allow out-of-range integers * string.c: String#setbyte to accept arbitrary integers [Bug #15460] * io.c: ditto for IO#ungetbyte * ext/strringio/stringio.c: ditto for StringIO#ungetbyte git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- io.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) (limited to 'io.c') diff --git a/io.c b/io.c index 24dacc5dd8..7de405de32 100644 --- a/io.c +++ b/io.c @@ -4258,23 +4258,17 @@ rb_io_ungetbyte(VALUE io, VALUE b) GetOpenFile(io, fptr); rb_io_check_byte_readable(fptr); - if (NIL_P(b)) return Qnil; - if (FIXNUM_P(b)) { - int i = FIX2INT(b); - if (0 <= i && i <= UCHAR_MAX) { - unsigned char cc = i & 0xFF; - b = rb_str_new((const char *)&cc, 1); - } - else { - rb_raise(rb_eRangeError, - "integer %d too big to convert into `unsigned char'", i); - } - } - else if (RB_TYPE_P(b, T_BIGNUM)) { - rb_raise(rb_eRangeError, "bignum too big to convert into `unsigned char'"); - } - else { - SafeStringValue(b); + switch (TYPE(b)) { + case T_NIL: + return Qnil; + case T_FIXNUM: + case T_BIGNUM: ; + VALUE v = rb_int_modulo(b, INT2FIX(256)); + unsigned char c = NUM2INT(v) & 0xFF; + b = rb_str_new((const char *)&c, 1); + break; + default: + SafeStringValue(b); } io_ungetbyte(b, fptr); return Qnil; -- cgit v1.2.3