From d0015e4ac6b812ea1681b1f5fa86fbab52a58960 Mon Sep 17 00:00:00 2001 From: watson1978 Date: Wed, 31 May 2017 12:30:57 +0000 Subject: Improve performance of implicit type conversion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To convert the object implicitly, it has had two parts in convert_type() which are 1. lookink up the method's id 2. calling the method Seems that strncmp() and strcmp() in convert_type() are slightly heavy to look up the method's id for type conversion. This patch will add and use internal APIs (rb_convert_type_with_id, rb_check_convert_type_with_id) to call the method without looking up the method's id when convert the object. Array#flatten -> 19 % up Array#+ -> 3 % up [ruby-dev:50024] [Bug #13341] [Fix GH-1537] ### Before Array#flatten 104.119k (± 1.1%) i/s - 525.690k in 5.049517s Array#+ 1.993M (± 1.8%) i/s - 10.010M in 5.024258s ### After Array#flatten 124.005k (± 1.0%) i/s - 624.240k in 5.034477s Array#+ 2.058M (± 4.8%) i/s - 10.302M in 5.019328s ### Test Code require 'benchmark/ips' class Foo def to_ary [1,2,3] end end Benchmark.ips do |x| ary = [] 100.times { |i| ary << i } array = [ary] x.report "Array#flatten" do |i| i.times { array.flatten } end x.report "Array#+" do |i| obj = Foo.new i.times { array + obj } end end git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'hash.c') diff --git a/hash.c b/hash.c index 61ca381ac7..3176bc7a24 100644 --- a/hash.c +++ b/hash.c @@ -711,13 +711,13 @@ rb_hash_s_create(int argc, VALUE *argv, VALUE klass) static VALUE to_hash(VALUE hash) { - return rb_convert_type(hash, T_HASH, "Hash", "to_hash"); + return rb_convert_type_with_id(hash, T_HASH, "Hash", idTo_hash); } VALUE rb_check_hash_type(VALUE hash) { - return rb_check_convert_type(hash, T_HASH, "Hash", "to_hash"); + return rb_check_convert_type_with_id(hash, T_HASH, "Hash", idTo_hash); } /* @@ -1027,7 +1027,7 @@ rb_hash_set_default_proc(VALUE hash, VALUE proc) SET_DEFAULT(hash, proc); return proc; } - b = rb_check_convert_type(proc, T_DATA, "Proc", "to_proc"); + b = rb_check_convert_type_with_id(proc, T_DATA, "Proc", idTo_proc); if (NIL_P(b) || !rb_obj_is_proc(b)) { rb_raise(rb_eTypeError, "wrong default_proc type %s (expected Proc)", -- cgit v1.2.3