From 68bc5ba1b6695f80623441cb60436801add42757 Mon Sep 17 00:00:00 2001 From: nobu Date: Thu, 26 Jun 2014 20:33:34 +0000 Subject: hash.c: fix memory leak * hash.c (env_shift): fix memory leak on Windows, free environment strings block always. [ruby-dev:48332] [Bug #9983] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- hash.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'hash.c') diff --git a/hash.c b/hash.c index bcf6b5e54b..348e5fb976 100644 --- a/hash.c +++ b/hash.c @@ -3554,6 +3554,7 @@ static VALUE env_shift(void) { char **env; + VALUE result = Qnil; env = GET_ENVIRON(environ); if (*env) { @@ -3562,11 +3563,11 @@ env_shift(void) VALUE key = env_str_new(*env, s-*env); VALUE val = env_str_new2(getenv(RSTRING_PTR(key))); env_delete(Qnil, key); - return rb_assoc_new(key, val); + result = rb_assoc_new(key, val); } } FREE_ENVIRON(environ); - return Qnil; + return result; } /* -- cgit v1.2.3